2:59 p.m.
The following changes since commit 8143dabb91939f8731853981528a7cdc460768a1:
iptraf.c: fix displaying long interface names (2012-11-28 10:20:30 +0100)
are available in the git repository at:
git://git.inai.de/iptraf master
for you to fetch changes up to ed6b73679dac063ef91c96e21aef26ca06e990b5:
build: prefer ncurses6 and wide (2013-03-28 20:56:11 +0100)
----------------------------------------------------------------
Jan Engelhardt (1):
build: prefer ncurses6 and wide
Makefile | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
2:59 p.m.
New subject: [PATCH] build: prefer ncurses6 and wide
Signed-off-by: Jan Engelhardt <jengelh(a)inai.de>
---
Makefile | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/Makefile b/Makefile
index c8711db..46e5632 100644
--- a/Makefile
+++ b/Makefile
@@ -245,18 +245,18 @@ endif
# try find ncuses by autodetect
ifndef NCURSES_LDFLAGS
- ifneq ($(shell ncurses5-config --libs 2>/dev/null),)
- NCURSES_CFLAGS := $(shell ncurses5-config --cflags 2>/dev/null)
- NCURSES_LDFLAGS := $(shell ncurses5-config --libs 2>/dev/null)
- else ifneq ($(shell ncursesw5-config --libs 2>/dev/null),)
- NCURSES_CFLAGS := $(shell ncursesw5-config --cflags 2>/dev/null)
- NCURSES_LDFLAGS := $(shell ncursesw5-config --libs 2>/dev/null)
+ ifneq ($(shell ncursesw6-config --libs 2>/dev/null),)
+ NCURSES_CFLAGS := $(shell ncursesw6-config --cflags 2>/dev/null)
+ NCURSES_LDFLAGS := $(shell ncursesw6-config --libs 2>/dev/null)
else ifneq ($(shell ncurses6-config --libs 2>/dev/null),)
NCURSES_CFLAGS := $(shell ncurses6-config --cflags 2>/dev/null)
NCURSES_LDFLAGS := $(shell ncurses6-config --libs 2>/dev/null)
- else ifneq ($(shell ncursesw6-config --libs 2>/dev/null),)
- NCURSES_CFLAGS := $(shell ncursesw6-config --cflags 2>/dev/null)
- NCURSES_LDFLAGS := $(shell ncursesw6-config --libs 2>/dev/null)
+ else ifneq ($(shell ncursesw5-config --libs 2>/dev/null),)
+ NCURSES_CFLAGS := $(shell ncursesw5-config --cflags 2>/dev/null)
+ NCURSES_LDFLAGS := $(shell ncursesw5-config --libs 2>/dev/null)
+ else ifneq ($(shell ncurses5-config --libs 2>/dev/null),)
+ NCURSES_CFLAGS := $(shell ncurses5-config --cflags 2>/dev/null)
+ NCURSES_LDFLAGS := $(shell ncurses5-config --libs 2>/dev/null)
endif
ifneq ($(NCURSES_LDFLAGS),)
--
1.8.2
3:10 p.m.
Hello Jan,
Jan Engelhardt <jengelh(a)inai.de> writes:
The following changes since commit
8143dabb91939f8731853981528a7cdc460768a1:
iptraf.c: fix displaying long interface names (2012-11-28 10:20:30 +0100)
are available in the git repository at:
git://git.inai.de/iptraf master
for you to fetch changes up to ed6b73679dac063ef91c96e21aef26ca06e990b5:
build: prefer ncurses6 and wide (2013-03-28 20:56:11 +0100)
----------------------------------------------------------------
Jan Engelhardt (1):
build: prefer ncurses6 and wide
Makefile | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
is there any good reason to prefer ncurses6?
--
Nikola
4:36 p.m.
On Thursday 2013-03-28 21:10, Nikola Pajkovsky wrote:
Hello Jan,
Jan Engelhardt <jengelh(a)inai.de> writes:
> The following changes since commit 8143dabb91939f8731853981528a7cdc460768a1:
>
> iptraf.c: fix displaying long interface names (2012-11-28 10:20:30 +0100)
>
> are available in the git repository at:
>
> git://git.inai.de/iptraf master
>
> for you to fetch changes up to ed6b73679dac063ef91c96e21aef26ca06e990b5:
>
> build: prefer ncurses6 and wide (2013-03-28 20:56:11 +0100)
>
> ----------------------------------------------------------------
> Jan Engelhardt (1):
> build: prefer ncurses6 and wide
>
> Makefile | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
is there any good reason to prefer ncurses6?
Is there any good reason to prefer ncurses5?
(nc6 has less collisions in the symbol namespace.. and the WIDE variant
has, on occassion, in the past, been the only one to render line-drawing
graphics correctly.)
3:44 a.m.
Jan Engelhardt <jengelh(a)inai.de> writes:
On Thursday 2013-03-28 21:10, Nikola Pajkovsky wrote:
>Hello Jan,
>
>Jan Engelhardt <jengelh(a)inai.de> writes:
>
>> The following changes since commit 8143dabb91939f8731853981528a7cdc460768a1:
>>
>> iptraf.c: fix displaying long interface names (2012-11-28 10:20:30 +0100)
>>
>> are available in the git repository at:
>>
>> git://git.inai.de/iptraf master
>>
>> for you to fetch changes up to ed6b73679dac063ef91c96e21aef26ca06e990b5:
>>
>> build: prefer ncurses6 and wide (2013-03-28 20:56:11 +0100)
>>
>> ----------------------------------------------------------------
>> Jan Engelhardt (1):
>> build: prefer ncurses6 and wide
>>
>> Makefile | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>
>
>is there any good reason to prefer ncurses6?
Is there any good reason to prefer ncurses5?
there's none, fedora/rhel doen't have nc6 so I preferred nc5.
I don't even see auto-detection as useful thing, it's there because it
was before with _configure_.
Header in Makefile say it clearly. If you need ncw6, define the variable
NEEDS_NCURSESW6 or use
make NEEDS_NCURSESW6=YesPlease
Anyway, it's harmless patch, so I pulled.
--
Nikola
10:16 a.m.
On Monday 2013-04-01 10:44, Nikola Pajkovsky wrote:
>
> Is there any good reason to prefer ncurses5?
there's none, fedora/rhel doen't have nc6 so I preferred nc5.
I don't even see auto-detection as useful thing, it's there because it
was before with _configure_.
Why was Makefile.am even removed? That's such a horrible step backwards.
Not only have you now a larger Makefile where you have to define all the
compiler commands yourself, but you also broke
./configure CFLAGS=-O1
this no longer places -O1 in the compiler command line.
3:21 a.m.
Jan Engelhardt <jengelh(a)inai.de> writes:
On Monday 2013-04-01 10:44, Nikola Pajkovsky wrote:
>>
>> Is there any good reason to prefer ncurses5?
>
>there's none, fedora/rhel doen't have nc6 so I preferred nc5.
>I don't even see auto-detection as useful thing, it's there because it
>was before with _configure_.
Why was Makefile.am even removed? That's such a horrible step backwards.
Not only have you now a larger Makefile where you have to define all the
compiler commands yourself, but you also broke
I don't know, if you are ever used the autotools in any bigger project,
but I found out, that it's faster and simple to not use
autostuff. Makefile has something around 458 lines of code *I know what
it does*. Previous configure and Makefiles have over 20+ lines of
generated code *I didn't even understand*. And m4 scripting language?
Don't make me say it loud.
./configure CFLAGS=-O1
I have to remove the backward compatibility with auto*shit* stuff. It
was never good step forward, anyway I was young.
this no longer places -O1 in the compiler command line.
yep, I don't care. you should use make CFLAGS=<what-ever-you-like-flags>
or put your CFLAGS in config.mak
--
Nikola
4042
days inactive
4047
days old
iptraf-ng@lists.fedorahosted.org
6 comments
2 participants
participants (2)
-
Jan Engelhardt -
Nikola Pajkovsky