From: Fedora Kernel Team kernel-team@fedoraproject.org
[redhat] New configs in arch/s390
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_DEBUG_ENTRY:
This option enables sanity checks in s390 low-level entry code. Some of these sanity checks may slow down kernel entries and exits or otherwise impact performance.
If unsure, say N.
Symbol: DEBUG_ENTRY [=n] Type : bool Defined at arch/s390/Kconfig.debug:9 Prompt: Debug low-level entry code Depends on: DEBUG_KERNEL [=y] Location: -> Kernel hacking -> s390 Debugging
---
Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
diff a/redhat/configs/common/generic/CONFIG_DEBUG_ENTRY b/redhat/configs/common/generic/CONFIG_DEBUG_ENTRY --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_ENTRY @@ -0,0 +1 @@ +# CONFIG_DEBUG_ENTRY is not set diff a/redhat/configs/pending-common/generic/CONFIG_DEBUG_ENTRY b/redhat/configs/pending-common/generic/CONFIG_DEBUG_ENTRY --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_ENTRY +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_DEBUG_ENTRY: -# -# This option enables sanity checks in s390 low-level entry code. -# Some of these sanity checks may slow down kernel entries and -# exits or otherwise impact performance. -# -# If unsure, say N. -# -# Symbol: DEBUG_ENTRY [=n] -# Type : bool -# Defined at arch/s390/Kconfig.debug:9 -# Prompt: Debug low-level entry code -# Depends on: DEBUG_KERNEL [=y] -# Location: -# -> Kernel hacking -# -> s390 Debugging -# -# -# -# CONFIG_DEBUG_ENTRY is not set
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/900
From: Cornelia Huck on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/900#note_55087016...
I now notice this one... this is the generic config option that should supersede DEBUG_USER_ASCE from mr !791.
DEBUG_ENTRY on s390 should follow the values on other architectures, I guess (x86 seems the only one so far?)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/900#note_55152191...
Since the config item can affect multiple arches now I think it is prudent to leave this MR as is with the option disabled in common/generic/. If some other arch begins using it we'll be all set.
From: Cornelia Huck on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/900#note_55510745...
Ok, keeping it in common/generic/ makes sense.
I see that arch/s390/configs/debug_defconfig enables this option; it would probably be a good idea to enable this for the debug kernel.
From: Cornelia Huck on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/900#note_55510951...
(for the _s390_ debug kernel)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/900#note_55593122...
Alright. I pushed a V2. It also removes the ark/generic/x86/x86_64/CONFIG_DEBUG_ENTRY file as it is redundant since it set the same value as our ommon/generic/CONFIG_DEBUG_ENTRY file.
From: Cornelia Huck on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/900#note_55619919...
Acked-by: Cornelia Huck cohuck@redhat.com
kernel@lists.fedoraproject.org
-
CKI Gitlab (via Email Bridge) -
Cornelia Huck (via Email Bridge)
-
Patrick Talbert (via Email Bridge)