From: "Justin M. Forbes" jforbes@fedoraproject.org
With upstream commit 7fe2de246e21f01212a8923fbabb4ac84c944d4a powerpc/vdso: Stripped VDSO is not needed, don't build it
the make targets for vdso_install are gone for ppc. If we call them, the build fails. This just turns them off.
Signed-off-by: Justin M. Forbes jforbes@fedoraproject.org --- redhat/kernel.spec.template | 1 + 1 file changed, 1 insertion(+)
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index 51e521c708d7..0638d9a7ca69 100755 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -379,6 +379,7 @@ Summary: The Linux kernel %define make_target vmlinux %define kernel_image vmlinux %define kernel_image_elf 1 +%define use_vdso 0 %define all_arch_configs kernel-%{version}-ppc64le*.config %endif
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/842#note_47795065...
Seems right. I would be interested if that compiles, installs and boots.
On Mon, Jan 4, 2021 at 7:42 PM GitLab Bridge on behalf of Don Zickus cki-gitlab@redhat.com wrote:
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/842#note_47795065...
Seems right. I would be interested if that compiles, installs and boots.
It compiles, I did a koji scratch build before submitting this. No clue on boots though.
Justin
* Justin Forbes:
On Mon, Jan 4, 2021 at 7:42 PM GitLab Bridge on behalf of Don Zickus cki-gitlab@redhat.com wrote:
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/842#note_47795065...
Seems right. I would be interested if that compiles, installs and boots.
It compiles, I did a koji scratch build before submitting this. No clue on boots though.
Do the vdso files still end up in the RPM? If not, I suspect that's going to cause issues when debugging.
There should be a file /lib/modules/*/vdso/vdso64.so.
Thanks, Florian
On Tue, Jan 5, 2021 at 9:35 AM Florian Weimer fweimer@redhat.com wrote:
- Justin Forbes:
On Mon, Jan 4, 2021 at 7:42 PM GitLab Bridge on behalf of Don Zickus cki-gitlab@redhat.com wrote:
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/842#note_47795065...
Seems right. I would be interested if that compiles, installs and boots.
It compiles, I did a koji scratch build before submitting this. No clue on boots though.
Do the vdso files still end up in the RPM? If not, I suspect that's going to cause issues when debugging.
There should be a file /lib/modules/*/vdso/vdso64.so.
You are right, this is going to be an issue. Will keep it tagged for release while I work on a more suitable long term fix that doesn't add too much complexity to the spec file.
Justin
On Tue, Jan 5, 2021 at 11:44 AM Justin Forbes jmforbes@linuxtx.org wrote:
On Tue, Jan 5, 2021 at 9:35 AM Florian Weimer fweimer@redhat.com wrote:
- Justin Forbes:
On Mon, Jan 4, 2021 at 7:42 PM GitLab Bridge on behalf of Don Zickus cki-gitlab@redhat.com wrote:
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/842#note_47795065...
Seems right. I would be interested if that compiles, installs and boots.
It compiles, I did a koji scratch build before submitting this. No clue on boots though.
Do the vdso files still end up in the RPM? If not, I suspect that's going to cause issues when debugging.
There should be a file /lib/modules/*/vdso/vdso64.so.
You are right, this is going to be an issue. Will keep it tagged for release while I work on a more suitable long term fix that doesn't add too much complexity to the spec file.
Actually, it seems that this is unnecessary, and the existing patch is correct. The separate vdso files are no longer created for power.
Justin
From: Herton Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/842#note_48401713...
Acked-by: Herton R. Krzesinski herton@redhat.com
From: Herton Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/842#note_49710545...
request-ack-nack-evaluation
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/842#note_49710564...
ACK/NACK Summary: NeedsReview - ACKed by Herton R. Krzesinski herton@redhat.com★. Requires at least 1 ACK(s) from someone in the set trix@redhat.com★, jlelli@redhat.com★, rvrbovsk@redhat.com★, dzickus@redhat.com★, bmeneg@redhat.com★, jforbes@fedoraproject.org★, jstancek@redhat.com★, dvlasenk@redhat.com★, lgoncalv@redhat.com★, ptalbert@redhat.com★, acaringi@redhat.com★, williams@redhat.com★, fhrbata@redhat.com★, bmasney@redhat.com★. Code owners are marked with a ★.
From: Herton Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/842#note_49710829...
@dzickusrh @jmflinuxtx I think is time to get this in os-build? Jiri Olsa was trying to build test I think from os-build and bumped into it too. I guess others will have same issue when contributing/test build from os-build.
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/842#note_49711513...
I would agree, we can't build without it, but I can't ack my own patch, so it needs another ack from someone.
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/842#note_49869426...
Acked-by: Don Zickus dzickus@redhat.com (via approve button)
kernel@lists.fedoraproject.org