From: CKI Gitlab on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1815 NOTE: Truncated patchset due to missing public @redhat.com email address on your GitLab profile at https://gitlab.com/-/profile. Once that is fixed, close and reopen the merge request to retrigger sending the emails.
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
Symbol: SFC_SIENA [=n] Type : tristate Defined at drivers/net/ethernet/sfc/siena/Kconfig:2 Prompt: Solarflare SFC9000 support Depends on: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_SOLARFLARE [=y] && PCI [=y] && PTP_1588_CLOCK [=y] Location: Main menu -> Device Drivers -> Network device support (NETDEVICES [=y]) -> Ethernet driver support (ETHERNET [=y]) -> Solarflare devices (NET_VENDOR_SOLARFLARE [=y]) Selects: MDIO [=m] && CRC32 [=y]
---
Cc: "Íñigo Huguet" ihuguet@redhat.com Cc: Jarod Wilson jarod@redhat.com Cc: Michal Schmidt mschmidt@redhat.com Cc: Petr Oros poros@redhat.com Cc: Ken Cox jkc@redhat.com Cc: "José Ignacio Tornos Martínez" jtornosm@redhat.com Cc: Kamal Heib kheib@redhat.com Cc: Stefan Assmann sassmann@redhat.com Cc: Corinna Vinschen vinschen@redhat.com Cc: Ivan Vecera ivecera@redhat.com Cc: Jonathan Toppins jtoppins@redhat.com Cc: Josef Oskera joskera@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
--- redhat/configs/ark/generic/CONFIG_SFC_SIENA | 1 + redhat/configs/pending-ark/generic/CONFIG_SFC_SIENA | 16 ---------------- 2 files changed, 1 insertions(+), 16 deletions(-)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1815#note_9624148...
Alright @ihuguet-rh. The commits will be squashed upon merge.
Thank you,
Patrick
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1815#note_9624421...
Ah, this opens up some other SIENA config items that need to be set:
~~~ CONFIG_SFC_SIENA_MTD=y CONFIG_SFC_SIENA_MCDI_MON=y CONFIG_SFC_SIENA_SRIOV=n CONFIG_SFC_SIENA_MCDI_LOGGING=y ~~~
Should we set these like this? Or enable SRIOV?
From: Íñigo Huguet on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1815#note_9625067...
Right now are all enabled (before the driver split, I mean) so I think better to enable all them here too.
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1815#note_9845211...
Thank you @ihuguet-rh. I think I have it right in v3.
From: Íñigo Huguet on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1815#note_9884152...
Patrick, I've double checked and it seems that right now SFC configs are only enabled for x86_64 and powerpc. My fault, I didn't see it in the first review. Please enabled these ones only for those archs, too.
@jwilsonrh do you know why they're enabled only for this archs?
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1815#note_9892495...
I believe the old thinking was that then-always-pci-less s390x would never need to build it (but I think some s390x variants have pci now?) and most embedded arm64 systems had no pci as well. I suspect we could enable this universally now, though I'm not sure if we want to turn on sienna for previously unsupported arches? Baseline sfc blanket enablement can be done for sure though.
From: Íñigo Huguet on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1815#note_9900289...
I agree about Siena, better keep as it was already, only for x86_64 and powerpc. @ptalbert please modify it.
About baseline sfc, I will ask about it and, in any case, I will open a separate MR for it.
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1815#note_9901789...
Thank you both. Done in v4 I hope.
From: Íñigo Huguet on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1815#note_9901834...
Approving, thanks and sorry for the extra work!
kernel@lists.fedoraproject.org