[OS-BUILD PATCH] virtio-rng: make device ready before making request

[Justin M. Forbes (via Email Bridge)]

From: Jason Wang <jasowang(a)redhat.com&gt;

virtio-rng: make device ready before making request

Current virtio-rng does a entropy request before DRIVER_OK, this
violates the spec:

virtio spec requires that all drivers set DRIVER_OK
before using devices.

Further, kernel will ignore the interrupt after commit
8b4ec69d7e09 ("virtio: harden vring IRQ").

Fixing this by making device ready before the request.

Cc: stable(a)vger.kernel.org
Fixes: 8b4ec69d7e09 ("virtio: harden vring IRQ")
Fixes: f7f510ec1957 ("virtio: An entropy device, as suggested by hpa.")
Reported-and-tested-by: syzbot+5b59d6d459306a556f54(a)syzkaller.appspotmail.com
Signed-off-by: Jason Wang <jasowang(a)redhat.com&gt;
Message-Id: <20220608061422.38437-1-jasowang(a)redhat.com&gt;
Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com&gt;
Reviewed-by: Laurent Vivier <lvivier(a)redhat.com&gt;

diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c
index blahblah..blahblah 100644
--- a/drivers/char/hw_random/virtio-rng.c
+++ b/drivers/char/hw_random/virtio-rng.c
@@ -159,6 +159,8 @@ static int probe_common(struct virtio_device *vdev)
 		goto err_find;
 	}
 
+	virtio_device_ready(vdev);
+
 	/* we always have a pending entropy request */
 	request_entropy(vi);
 

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1861

[Justin M. Forbes (via Email Bridge)]

From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1861#note_9880...

Upstream now.