rpmbuild warning message

[Markus Kesaromous]

In building 2.6.29..6-217.2.8.fc11 from source rpm for i586 architecture on a machine with
amd athlon64 cpu, I get this warning message:

arch/x86/kernel/pvclock.c:63:7: warning: "__x86_64__" is not defined


Thing is, I have no problems running i586 kernel, and even the resulting kernel runs fine.
It appears to be an error in the code, where

#elif __x86_64__    ought to be changed to

#elif defined(__x86_64__)


Cheers,

MK

_________________________________________________________________
Get back to school stuff for them and cashback for you.
http://www.bing.com/cashback?form=MSHYCB&publ=WLHMTAG&crea=TEXT_M...

[Paul Bolle]

On Thu, 2009-08-20 at 22:21 -0700, Markus Kesaromous wrote:
>  In building 2.6.29..6-217.2.8.fc11 from source rpm for i586
>  architecture on a machine with amd athlon64 cpu, I get this warning
>  message:
>  
>  arch/x86/kernel/pvclock.c:63:7: warning: "__x86_64__" is not defined 
See commit 2ad76643ff58bb8841f391ea8327c14abe273ea3 ("x86: Fix warning
in pvclock.c") for the identical fix in the upstream kernel (i.e. Linus'
git tree).


Paul Bolle

[Markus Kesaromous]

----------------------------------------
>  From: pebolle(a)tiscali.nl
>  To: remotestar(a)live.com
>  Date: Fri, 21 Aug 2009 11:30:46 +0200
>  CC: fedora-kernel-list(a)redhat.com
>  Subject: Re: rpmbuild warning message
>
>  On Thu, 2009-08-20 at 22:21 -0700, Markus Kesaromous wrote:
> > In building 2.6.29..6-217.2.8.fc11 from source rpm for i586
> > architecture on a machine with amd athlon64 cpu, I get this warning
> > message:
> >
> > arch/x86/kernel/pvclock.c:63:7: warning: "__x86_64__" is not defined
>
>  See commit 2ad76643ff58bb8841f391ea8327c14abe273ea3 ("x86: Fix warning
>  in pvclock.c") for the identical fix in the upstream kernel (i.e. Linus'
>  git tree).
>
>
>  Paul Bolle 
Thank you Paul. There are numerous other warnings which seem to be inconsequential as far
as compilation goes. I was wondering if there is
a concerted effort to thouroughly lint the kernel and get rid of all those
warnings.

Cheers,
MK

_________________________________________________________________
Windows Live: Keep your friends up to date with what you do online.
http://windowslive.com/Campaign/SocialNetworking?ocid=PID23285::T:WLMTAGL...

[Paul Bolle]

On Fri, 2009-08-21 at 08:24 -0700, Markus Kesaromous wrote:
>  There are numerous other warnings which seem to be inconsequential
> as
>  far as compilation goes. I was wondering if there is a concerted
>  effort to thoroughly lint the kernel and get rid of all those
>  warnings. 
The kernel build system is very quiet by default. As far as I know it is
that quiet (among other things) to make warnings stand out. Valid fixes
for warnings (as the commit I pointed you to) should be accepted without
too much trouble.


Paul Bolle