3:54 p.m.
On Mon, Dec 19, 2011 at 09:48:06PM +0000, Dave Jones wrote:
commit f76e0239ae4715d34b39397046b51825fb3fa47c
Author: Dave Jones <davej(a)redhat.com>
Date: Mon Dec 19 16:47:56 2011 -0500
This should never be =y
Looks like nobody noticed when it changed from a bool to a tristate in
2006...
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 31) config
DEV_APPLETALK
9cac2c35 (David S. Miller 2006-07-30 20:20:54 -0700 32) tristate
"Appletalk interfaces support"
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 33) depends
on ATALK
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 34) help
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 35)
AppleTalk is the protocol that Apple computers can use to communicate
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 36) on a
network. If your Linux box is connected to such a network, and wish
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 37) to do
IP over it, or you have a LocalTalk card and wish to use it to
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 38)
connect to the AppleTalk network, say Y.
This isn't the first time this has happened...
--Kyle
4:25 p.m.
New subject: [kernel] This should never be =y
On Mon, Dec 19, 2011 at 04:54:55PM -0500, Kyle McMartin wrote:
On Mon, Dec 19, 2011 at 09:48:06PM +0000, Dave Jones wrote:
> commit f76e0239ae4715d34b39397046b51825fb3fa47c
> Author: Dave Jones <davej(a)redhat.com>
> Date: Mon Dec 19 16:47:56 2011 -0500
>
> This should never be =y
>
Looks like nobody noticed when it changed from a bool to a tristate in
2006...
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 31) config
DEV_APPLETALK
9cac2c35 (David S. Miller 2006-07-30 20:20:54 -0700 32) tristate
"Appletalk interfaces support"
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 33) depends
on ATALK
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 34) help
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 35)
AppleTalk is the protocol that Apple computers can use to communicate
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 36) on a
network. If your Linux box is connected to such a network, and wish
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 37) to do
IP over it, or you have a LocalTalk card and wish to use it to
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 38)
connect to the AppleTalk network, say Y.
This isn't the first time this has happened...
Turns out we were getting lucky anyway, as it depended on CONFIG_ATALK, which
was modular.
Dave
4:32 p.m.
New subject: [kernel] This should never be =y
On Mon, Dec 19, 2011 at 05:25:31PM -0500, Dave Jones wrote:
Turns out we were getting lucky anyway, as it depended on
CONFIG_ATALK, which
was modular.
Ah, that's a relief. I have an idea for how we can monitor this sort of
thing and try to prevent it from occuring in the future... I'll see what
I can do in January.
--Kyle
4:43 p.m.
New subject: [kernel] This should never be =y
On Mon, Dec 19, 2011 at 05:32:21PM -0500, Kyle McMartin wrote:
On Mon, Dec 19, 2011 at 05:25:31PM -0500, Dave Jones wrote:
> Turns out we were getting lucky anyway, as it depended on CONFIG_ATALK, which
> was modular.
>
Ah, that's a relief. I have an idea for how we can monitor this sort of
thing and try to prevent it from occuring in the future... I'll see what
I can do in January.
We can almost do it automatically.
scripts/sort-config has a mode to check for options changing state
from what we set them. But it gets confused by the way we do overrides and
thus spews a bunch of false positives.
so if we did a pass through the generated file post merge.pl, but pre oldconfig,
to weed out the duplicates (just keep the last version of every symbol),
I think we could just pass the result to sort-config -m to find out what's
getting changed.
it still won't catch the 'bool became tristate' in all cases, but if
there's
a dependant symbol as there was in this case, it should get flagged.
Dave
4512
days inactive
4512
days old
kernel@lists.fedoraproject.org
3 comments
3 participants
participants (3)
-
Dave Jones -
Kyle McMartin -
Kyle McMartin