From: Ondrej Mosnacek omosnace@redhat.com
process_configs.sh: fix find/xargs data flow
`xargs -0` expects arguments delimited by \0 on stdin, but instead it recieves a list of filenames delimited by \n from `find`. Fix that by adding `-print0` to `find` so that it outputs the filenames delimited by \0 as xargs expects.
Signed-off-by: Ondrej Mosnacek omosnace@redhat.com
diff a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh --- a/redhat/configs/process_configs.sh +++ b/redhat/configs/process_configs.sh @@ -79,7 +79,7 @@ checkoptions() then while read -r LINE do - if find ./ -name "$(echo "$LINE" | awk -F "=" ' { print $1 } ' | awk ' { print $2 }')" | xargs -0 grep ^ | grep -q "process_configs_known_broken"; then + if find ./ -name "$(echo "$LINE" | awk -F "=" ' { print $1 } ' | awk ' { print $2 }')" -print0 | xargs -0 grep ^ | grep -q "process_configs_known_broken"; then # This is a known broken config. # See script help warning. checkoptions_error=false
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/885
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/885#note_50272825...
I was trying to fix this a couple of weeks, but got sidetracked. I like your change better than the hack I was pursing. Thanks!
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/885#note_50272829...
Acked-by: Don Zickus dzickus@redhat.com (via approve button)
From: Ondrej Mosnacek omosnace@redhat.com
process_configs.sh: fix find/xargs data flow
`xargs -0` expects arguments delimited by \0 on stdin, but instead it recieves a list of filenames delimited by \n from `find`. Fix that by adding `-print0` to `find` so that it outputs the filenames delimited by \0 as xargs expects.
Signed-off-by: Ondrej Mosnacek omosnace@redhat.com
diff a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh --- a/redhat/configs/process_configs.sh +++ b/redhat/configs/process_configs.sh @@ -79,7 +79,7 @@ checkoptions() then while read -r LINE do - if find ./ -name "$(echo "$LINE" | awk -F "=" ' { print $1 } ' | awk ' { print $2 }')" | xargs -0 grep ^ | grep -q "process_configs_known_broken"; then + if find ./ -name "$(echo "$LINE" | awk -F "=" ' { print $1 } ' | awk ' { print $2 }')" -print0 | xargs -0 grep ^ | grep -q "process_configs_known_broken"; then # This is a known broken config. # See script help warning. checkoptions_error=false
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/885
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/885#note_50680144...
Ah this is what I was hitting yesterday: https://gitlab.com/cki- project/kernel-ark/-/merge_requests/652#note_506124029
@bcrocker ^
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/885#note_50680190...
request-evaluation
kernel@lists.fedoraproject.org
-
cki-gitlab＠redhat.com -
Ondrej Mosnáček (via Email Bridge)