From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
---
Cc: "Michael S. Tsirkin" mst@redhat.com Cc: Jason Wang jasowang@redhat.com Cc: rhvirt-patches@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- redhat/configs/common/generic/CONFIG_VDPA_SIM_NET | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_VDPA_SIM_NET
diff --git a/redhat/configs/common/generic/CONFIG_VDPA_SIM_NET b/redhat/configs/common/generic/CONFIG_VDPA_SIM_NET new file mode 100644 index 000000000000..e69de29bb2d1
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/837#note_49292435...
This MR really depends on what happens to https://gitlab.com/cki- project/kernel-ark/-/merge_requests/321 .
From: Jason Wang on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/837#note_55207593...
I wan to ack but it looks to me "/approve" doesn't work and I get
"Could not apply approve command."
I guess the issue is that I am not granted to ack for kernel-ark?
From: Stefano Garzarella on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/837#note_55222783...
I'm not sure is related, but in `redhat/configs/fedora/generic` we set `CONFIG_VDPA_SIM=m`. Starting from 5.11, we have `CONFIG_VDPA_SIM_NET` to enable the vdpa-net simulator, so I think we should set `CONFIG_VDPA_SIM_NET=m` for fedora.
I opened a BZ for this issue: https://bugzilla.redhat.com/show_bug.cgi?id=1942343
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/837#note_55260009...
@sgarzarella That wouldn't be a part of this MR, but I just turned it on for Fedora, it will be enabled starting with kernel-5.11.15.
From: Stefano Garzarella on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/837#note_55268975...
This is great, thank you so much!
From: Jason Wang on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/837#note_55319630...
Acked-by: Jason Wang jasowang@redhat.com
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/837#note_55344042...
This silly broken MR does not actually set a value for CONFIG_VDPA_SIM_NET under redhat/configs/common/generic/; it simply creates an empty file there. I take it we should enable VDPA_SIM_NET as a module?
Until someone says:
Nacked-by: Patrick Talbert ptalbert@redhat.com
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/837#note_55345946...
Ah. So CONFIG_VDPA_SIM_NET depends on CONFIG_VDPA_SIM and CONFIG_VDPA but at the time this MR was generated those configs were not enabled. So we bumped into this bug with the MR generation: cki-project/kernel- ark#40.
Now that we have CONFIG_VDPA enabled via cki-project/kernel-ark!321, these are configs are relevant and a new MR has been auto created (correctly!):
cki-project/kernel-ark!1032
So I close this in favour of !1032.
kernel@lists.fedoraproject.org
-
cki-gitlab＠redhat.com -
GitLab Bridge on behalf of redhat-patchlab
-
Jason Wang (via Email Bridge)
-
Justin Forbes (via Email Bridge)
-
Patrick Talbert (via Email Bridge)
-
Stefano Garzarella (via Email Bridge)