[OS-BUILD PATCH 0/0] [redhat] New configs in init/Kconfig

[CKI Gitlab (via Email Bridge)]

From: CKI Gitlab on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1828
NOTE: Truncated patchset due to missing public @redhat.com email
      address on your GitLab profile at https://gitlab.com/-/profile.
      Once that is fixed, close and reopen the merge request to
      retrigger sending the emails.

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

Symbol: MODULE_UNLOAD_TAINT_TRACKING [=n]
 Type  : bool
 Defined at init/Kconfig:1986
   Prompt: Tainted module unload tracking
   Depends on: MODULES [=y] && MODULE_UNLOAD [=y]
   Location:
     Main menu
       -> Enable loadable module support (MODULES [=y])
         -> Module unloading (MODULE_UNLOAD [=y])

---

Cc: Prarit Bhargava 
Cc: Aristeu Rozanski 
Cc: Artem Savkov 
Cc: Clark Williams 
Cc: "Herton R. Krzesinski" 
Cc: Jan Stancek 
Cc: Josh Poimboeuf 
Signed-off-by: Fedora Kernel Team

---
 redhat/configs/ark/generic/CONFIG_MODULE_UNLOAD_TAINT_TRACKING         |   1 +
 redhat/configs/pending-ark/generic/CONFIG_MODULE_UNLOAD_TAINT_TRACKING |  13 ----------
 2 files changed, 1 insertions(+), 13 deletions(-)

[Patrick Talbert (via Email Bridge)]

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1828#note_9640124...

Alright. I added a commit to change this and set the MR to squash everything
upon merge.

[Ondrej Mosnáček (via Email Bridge)]

From: Ondrej Mosnáček on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1828#note_9641085...

How about enabling it also in Fedora at the same time (i.e. removing both the
pending-ark and pending-fedora entries and adding a =y setting to common)?

[Patrick Talbert (via Email Bridge)]

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1828#note_9641639...

@omos these MRs handle ark changes. The `pending-fedora` files are handled by
@jmflinuxtx without MRs as they do not require RH review.

[Ondrej Mosnáček (via Email Bridge)]

From: Ondrej Mosnáček on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1828#note_9678519...

OK, but wouldn't it save @jmflinuxtx some work if the Fedora configs are
consolidated in the same MR rather than him having to add another commit that
consolidates them into `common/` later? (At least in cases where it's obvious
what the intended Fedora config will be.)

I don't really care either way, but it seems to be a slightly inefficient
process...

[Patrick Talbert (via Email Bridge)]

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1828#note_9691627...

Just because something is in pending-fedora doesn't mean it is going to end up
that way under `fedora/`. It is for @jmflinuxtx and the fedora maintainers to
decide how the pending-fedora stuff is to be handled. Any pending config item
is from "dumb" automation creating a config file with a default setting and it
is not unusual for ark or fedora to not want to use that setting.

I appreciate in most cases it is "obvious" what the setting should be for
everyone but IMHO it keeps things simple if these MRs do not alter fedora
content. If we modify fedora content here then they must block on fedora
review and that can slow down ark.

Keep in mind that from time to time we run a script that consolidates matching
items under ark/fedora into common so we don't have to worry about that aspect
either in these MRs.

[Justin M. Forbes (via Email Bridge)]

From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1828#note_9693553...

@omos It seems like it would, but in practice it does not. I typically sit
down and do a large number of fedora configs in a one sitting, one commit.
Particularly for obvious ones, each config item takes me less time than it
takes me to click on an MR, read the context, and click approve.  As I get an
email for every MR comment on the whole repo, I do see the feedback given on
the RHEL comnfig MRs and take that into consideration.   Of course if
something is moved out of pending, and someone feels that it should be changed
from what I set, I am happy to take an MR to change it.
The commit that would consolidate Fedora and ark into common is actually a
single script that runs. I verify that the generated config files are
identical before and after the script runs, but it really is a single verify
and a single commit, whether it consolidates a single item or 100 items.