[OS-BUILD PATCH 0/0] [redhat] New configs in net/netfilter

[CKI Gitlab (via Email Bridge)]

From: CKI Gitlab on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1209
NOTE: Truncated patchset due to missing public @redhat.com email
      address on your GitLab profile at https://gitlab.com/-/profile.
      Once that is fixed, close and reopen the merge request to
      retrigger sending the emails.

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

CONFIG_NETFILTER_NETLINK_HOOK:

If this option is enabled, the kernel will include support
 to list the base netfilter hooks via NFNETLINK.
 This is helpful for debugging.

Symbol: NETFILTER_NETLINK_HOOK [=n]
 Type  : tristate
 Defined at net/netfilter/Kconfig:22
   Prompt: Netfilter base hook dump support
   Depends on: NET [=y] && INET [=y] && NETFILTER [=y] && NETFILTER_ADVANCED
[=y] && NF_TABLES [=m]
   Location:
     -> Networking support (NET [=y])
       -> Networking options
         -> Network packet filtering framework (Netfilter) (NETFILTER [=y])
           -> Core Netfilter Configuration
 Selects: NETFILTER_NETLINK [=m]

---

Cc: Florian Westphal 
Cc: Jiri Benc 
Cc: Marcelo Leitner 
Cc: Antoine Tenart 
Cc: Balazs Nemeth 
Cc: Davide Caratti 
Cc: Eric Garver 
Cc: Flavio Leitner 
Cc: Guillaume Nault 
Cc: Hangbin Liu 
Cc: Ivan Vecera 
Cc: Jarod Wilson 
Cc: Lorenzo Bianconi 
Cc: Paolo Abeni 
Cc: Phil Sutter 
Cc: Sabrina Dubroca 
Cc: Stefano Brivio 
Cc: Xin Long 
Signed-off-by: Fedora Kernel Team

---
 redhat/configs/common/generic/CONFIG_NETFILTER_NETLINK_HOOK         |   1 +
 redhat/configs/pending-common/generic/CONFIG_NETFILTER_NETLINK_HOOK |  21 ----------
 2 files changed, 1 insertions(+), 21 deletions(-)

[Patrick Talbert (via Email Bridge)]

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1209#note_6174833...

Alright. I have made that change.

Note all commits in this MR will be squashed upon merge.

[Jarod Wilson (via Email Bridge)]

From: Jarod Wilson on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1209#note_6300634...

Is there a reason this is broken out into two commits instead of just being
one? And should there be something further in the series explaining why the
second patch is toggling this value on, when it was off in pending?

[Patrick Talbert (via Email Bridge)]

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1209#note_6409921...

For very simple changes such as toggling a config option I have sometimes
edited the file with gitlab's UI which creates a new commit. But then we
squash the commits upon merge.

In the instances where I checkout the branch, edit, and push the change, I
typically amend the commit message with a V2 line showing _what_ I toggled,
but not _why_. In many cases I do not have a "why" beyond some RH SME
suggesting they would like it changed and we'll have the MR history and
mailing list history if we ever want to go back to see that...

[Marcelo Ricardo Leitner (via Email Bridge)]

From: Marcelo Ricardo Leitner on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1209#note_6424730...

AFAICT this is ready to fly now.

[Marcelo Ricardo Leitner (via Email Bridge)]

From: Marcelo Ricardo Leitner on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1209#note_6424740...

I don't see the Approve button, so:
Acked-by: Marcelo Ricardo Leitner

fingers crossed ;-)

[Jarod Wilson (via Email Bridge)]

From: Jarod Wilson on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1209#note_6434910...

Okay, fair enough.

[Jarod Wilson (via Email Bridge)]

From: Jarod Wilson on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1209#note_6434912...

Acked-by: Jarod Wilson 
(via approve button)