4:37 a.m.
Hi,
I stumbled over this while looking into something completely different,
according to:
https://bugzilla.kernel.org/show_bug.cgi?id=172411
As this point in time it is better to not enable
CONFIG_IWLWIFI_PCIE_RTPM, as it cause wifi disconnects
on some platforms.
Regards,
Hans
6:01 a.m.
On Thu, Dec 15, 2016 at 5:37 AM, Hans de Goede <hdegoede(a)redhat.com> wrote:
Hi,
I stumbled over this while looking into something completely different,
according to:
https://bugzilla.kernel.org/show_bug.cgi?id=172411
As this point in time it is better to not enable
CONFIG_IWLWIFI_PCIE_RTPM, as it cause wifi disconnects
on some platforms.
There's no indication in the code that it's broken or unsafe to
enable. Seems like a patch making it depend on config BROKEN or
config EXPERT or at least some kind of warning in the help text is
warranted.
josh
6:26 a.m.
Hi,
On 15-12-16 13:01, Josh Boyer wrote:
On Thu, Dec 15, 2016 at 5:37 AM, Hans de Goede
<hdegoede(a)redhat.com> wrote:
> Hi,
>
> I stumbled over this while looking into something completely different,
> according to:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=172411
>
> As this point in time it is better to not enable
> CONFIG_IWLWIFI_PCIE_RTPM, as it cause wifi disconnects
> on some platforms.
There's no indication in the code that it's broken or unsafe to
enable. Seems like a patch making it depend on config BROKEN or
config EXPERT or at least some kind of warning in the help text is
warranted.
That seems like a good idea to me, I've added a comment about this
to the upstream bug.
Regards,
Hans
12:18 p.m.
On 12/15/2016 12:01 PM, Josh Boyer wrote:
On Thu, Dec 15, 2016 at 5:37 AM, Hans de Goede
<hdegoede(a)redhat.com> wrote:
> Hi,
>
> I stumbled over this while looking into something completely different,
> according to:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=172411
>
> As this point in time it is better to not enable
> CONFIG_IWLWIFI_PCIE_RTPM, as it cause wifi disconnects
> on some platforms.
There's no indication in the code that it's broken or unsafe to
enable. Seems like a patch making it depend on config BROKEN or
config EXPERT or at least some kind of warning in the help text is
warranted.
It's pretty clear from comment 7 in that upstream report that upstream
does not deem it safe to have this option enabled at this point...
" It's safer to keep it disabled for now. We'll let you know when
setting this option actually becomes beneficial for general platforms."
JBG
12:41 p.m.
On Tue, Dec 20, 2016 at 1:18 PM, Jóhann B. Guðmundsson
<johannbg(a)gmail.com> wrote:
On 12/15/2016 12:01 PM, Josh Boyer wrote:
> On Thu, Dec 15, 2016 at 5:37 AM, Hans de Goede <hdegoede(a)redhat.com>
> wrote:
>>
>> Hi,
>>
>> I stumbled over this while looking into something completely different,
>> according to:
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=172411
>>
>> As this point in time it is better to not enable
>> CONFIG_IWLWIFI_PCIE_RTPM, as it cause wifi disconnects
>> on some platforms.
>
> There's no indication in the code that it's broken or unsafe to
> enable. Seems like a patch making it depend on config BROKEN or
> config EXPERT or at least some kind of warning in the help text is
> warranted.
It's pretty clear from comment 7 in that upstream report that upstream does
not deem it safe to have this option enabled at this point...
Yes, in the bug report. My reply you quoted said "... in the
code...". My point was, if upstream considered this unsafe they
should have indicated it in the code to begin with. That way people
don't turn it on before they consider it ready.
josh
2683
days inactive
2688
days old
kernel@lists.fedoraproject.org
4 comments
3 participants
participants (3)
-
Hans de Goede -
Josh Boyer -
Jóhann B. Guðmundsson