Hi Dave,
Thanks for your feedback.
On Fri, Apr 29, 2016 at 3:13 PM, Xunlei Pang <xpang(a)redhat.com> wrote:
On 2016/04/29 at 17:16, Dave Young wrote:
> Hi, Pratyush and xunlei
>
> On 04/29/16 at 12:20pm, Pratyush Anand wrote:
>> Kexec-tools should be able to recognize if a dump target is reformatted, or
>> dump path mounts another device.
>>
>> Changes since v4:
>> - patch 4/5 is a new change
>> - patch 4/4 of V3 is now 4/5. There has been many modifications in this
>> patch. It includes feedback from Baoquan and Xunlei. Have also done some
>> modification to recognize changes related to minix and NFS filesystem as
>> well. Infact, whole structure of function is_fs_uuid_changed() has been
>> modified. Now it has been renamed as is_dump_fs_modified() to suit it
>> better. Although I have tested it rigorously, but still a careful review
>> of is_dump_fs_modified() will be helpful.
>>
> I feel we are doing too much, for example the fs type changes. Should we
> really allow that especially for user specified dump targets in /etc/kdump.conf?
>
In fact explicit modification of user specified dump target in
kdump.conf is not an issue. That is well detected by
is_files_modified() which has higher precedence over
is_dump_fs_modified(). These patches are mostly to take care of the
cases when "dump path" mounts a bulk or nfs target. Patch 5/5 will
help to detect if either there is a change in the bulk mounted device
or "dump path" mounts to another bulk device/nfs directory.
For example:
/var/crash was mounting /dev/sdb1, but now it mounts /dev/sdc1
/var/crash was mounting /dev/sdb1, but now /dev/sdb1 has been
reformatted to either same file-system type or different file-system
type.
/var/crash was mounting 192.168.1.16:/nfsroot, but now it mounts
192.168.1.12:/nfsroot
~Pratyush