Re: [PATCH v2 00/13] various fixes and cleanups
Hi Philipp,
Thanks for your efforts! The patch set has been merged.
Reviewed-by: Coiby Xu <coxu(a)redhat.com>
On Thu, Jan 12, 2023 at 04:30:58PM +0100, Philipp Rudo wrote:
Hi everybody,
here are a few patches before I go on Christmas vacation. I'll be back in
office on Jan 9th so you don't need to hurry to review them.
Patch 3 is a little bit special as in my opinion it only highlights the problem
but doesn't really fix it. For a proper fix one would need to move all
functions dracut-early-kdump.sh uses from kdump-lib to kdump-lib-initramfs and
make them POSIX compliant...
Thanks and see you next year
Philipp
---
v1->v2:
* incorporate Coibys comments, i.e. disable shellcheck in patch 2 rather than
quoting EARLY_KEXEC_ARGS and move image_time to check_files_modified and
make it local in patch 13.
Philipp Rudo (13):
kdumpctl: simplify check_failure_action_config
dracut-early-kdump: fix shellcheck findings
dracut-early-kdump: explicitly use bash
kdumpctl: merge check_current_{kdump,fadump}_status
mkfadumprd: drop unset globals from debug output
kdump-lib: always specify version in is_squash_available
unit tests: add tests for prepare_cmdline
kdumpctl: move aws workaround to kdump-lib
kdump-lib: fix prepare_cmdline
kdumpctl: cleanup 'start'
kdumpctl: cleanup 'stop'
kdumpctl: refractor check_rebuild
kdumpctl: make do_estimate more robust
.editorconfig | 2 +-
dracut-early-kdump.sh | 6 +-
kdump-lib.sh | 226 +++++++++++++++++--------------
kdumpctl | 296 +++++++++++++++--------------------------
mkfadumprd | 2 +-
spec/kdump-lib_spec.sh | 32 +++++
6 files changed, 272 insertions(+), 292 deletions(-)
mode change 100644 => 100755 mkfadumprd
--
2.39.0
--
Best regards,
Coiby