On Fri, Aug 16, 2013 at 11:04:10AM +0800, WANG Chao wrote:
> On 08/15/13 at 11:25am, Vivek Goyal wrote:
> > On Thu, Aug 15, 2013 at 03:42:27PM +0800, WANG Chao wrote:
> > > Now kdump.service runs "After" network.target. But
> > > doesn't mean network is setup and online. We should use
> > > network-online.target instead for ssh/nfs dump.
> > >
> > > And also because nfs dump requires a mounted nfs when rebuilding kdump
> > > initrd, kdump.service should also run "After" remote-fs.target
> > > means all remote fs configured in /etc/fstab is mounted).
> > >
> > > 1. http://www.freedesktop.org/wiki/Software/systemd/NetworkTarget
> > >
> > > Signed-off-by: WANG Chao <chaowang(a)redhat.com>
> > I think this dependency might create some issues. What if kdump.conf is
> > not dumping to an nfs/ssh target. What if there is a configuration issue
> > and a network interface is not coming up. Does that mean kdump service
> > will not run at all in that case?
> Kdump will run, because kdump don't "Wants" or "Requires"
> these service/target (ie, kdump won't pull in them if they're disabled).
> "After" means if kdump will try to run after these services/target, but
> if these services/target aren't enabled or pulled in by other service
> ("Requires" or "Wants"). Kdump service will simply ignore the
> ones and run after the enabled ones.
So who is supposed to enable/disable network-online.target. And by default
is it enabled?
Emm.. network-online.target is a static unit. It's passive and can't be
enabled standalone. It can be enabled(or pull in) by other service/target.
remote-fs.target (ex: nfs mount in /etc/fstab) will enable
And bz997318 I opened, is supposed to enable network-online.target if
NetworkManager-wait-online.target is enabled.