uname initdir and etc. are from dracut. In these cases, SC2154 warnings
are false positive for a dracut module.
Signed-off-by: Coiby Xu <coxu(a)redhat.com>
---
dracut-fadump-module-setup.sh | 2 ++
dracut-module-setup.sh | 8 +++++++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/dracut-fadump-module-setup.sh b/dracut-fadump-module-setup.sh
index f062486..8afbfec 100644
--- a/dracut-fadump-module-setup.sh
+++ b/dracut-fadump-module-setup.sh
@@ -9,7 +9,9 @@ depends() {
}
install() {
+ # shellcheck disable=SC2154 # $initdir is a dracut variable
mv -f "$initdir/init" "$initdir/init.dracut"
+ # shellcheck disable=SC2154 # $moddir is a dracut variable
inst_script "$moddir/init-fadump.sh" /init
chmod a+x "$initdir/init"
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index 4c6096a..21c0e70 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -1,6 +1,7 @@
#!/bin/bash
kdump_module_init() {
+ # shellcheck disable=SC2154 # $initdir is a dracut variable
if ! [[ -d "${initdir}/tmp" ]]; then
mkdir -p "${initdir}/tmp"
fi
@@ -9,6 +10,7 @@ kdump_module_init() {
}
check() {
+ # shellcheck disable=SC2154 # $debug is a dracut variable
[[ $debug ]] && set -x
#kdumpctl sets this explicitly
if [[ -z $IN_KDUMP ]] || [[ ! -f /etc/kdump.conf ]]; then
@@ -23,6 +25,7 @@ depends() {
kdump_module_init
add_opt_module() {
+ # shellcheck disable=SC2154 # $omit_dracutmodules is a dracut variable
[[ " $omit_dracutmodules " != *\ $1\ * ]] && _dep="$_dep
$1"
}
@@ -851,7 +854,7 @@ kdump_check_iscsi_targets() {
done
[[ -d iscsi_session ]] && kdump_setup_iscsi_device "$PWD"
)
-
+ # shellcheck disable=SC2154 # $hostonly and $mount_needs are from dracut
[[ $hostonly ]] || [[ $mount_needs ]] && {
for_each_host_dev_and_slaves_all kdump_check_setup_iscsi
}
@@ -906,6 +909,7 @@ get_pcs_fence_kdump_nodes() {
for node in ${nodelist}; do
# convert $node from 'uname="nodeX"' to 'nodeX'
eval "$node"
+ # shellcheck disable=SC2154 # $uname from dracut
nodename="$uname"
# Skip its own node name
if is_localhost "$nodename"; then
@@ -1039,6 +1043,7 @@ install() {
kdump_install_random_seed
fi
dracut_install -o /etc/adjtime /etc/localtime
+ # shellcheck disable=SC2154 # $uname and ${initdir} from dracut
inst "$moddir/monitor_dd_progress"
"/kdumpscripts/monitor_dd_progress"
chmod +x "${initdir}/kdumpscripts/monitor_dd_progress"
inst "/bin/dd" "/bin/dd"
@@ -1058,6 +1063,7 @@ install() {
inst "/lib/kdump/kdump-lib-initramfs.sh"
"/lib/kdump-lib-initramfs.sh"
inst "/lib/kdump/kdump-logger.sh" "/lib/kdump-logger.sh"
inst "$moddir/kdump.sh" "/usr/bin/kdump.sh"
+ # shellcheck disable=SC2154 # $systemdsystemunitdir from dracut
inst "$moddir/kdump-capture.service"
"$systemdsystemunitdir/kdump-capture.service"
systemctl -q --root "$initdir" add-wants initrd.target
kdump-capture.service
# Replace existing emergency service and emergency target
--
2.37.1