Thanks for the review Dave,
On Tue, Jun 13, 2017 at 12:18 PM, Dave Young <dyoung(a)redhat.com> wrote:
Hi Bhupesh,
On 06/08/17 at 06:44pm, Bhupesh Sharma wrote:
> Presently kdump-dep-generator.sh uses '/usr/lib/kdump/kdump-lib.sh'
> as the path to source the kdump-lib.sh helper script, whereas the rest
> of the kdump helper scripts use the convention
> '/lib/kdump/kdump-lib.sh'.
>
> Use the later convention in kdump-dep-generator.sh as well.
>
> Signed-off-by: Bhupesh Sharma <bhsharma(a)redhat.com>
> ---
> kdump-dep-generator.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kdump-dep-generator.sh b/kdump-dep-generator.sh
> index b6fab2dbe68c..e1ae1af9f244 100644
> --- a/kdump-dep-generator.sh
> +++ b/kdump-dep-generator.sh
> @@ -3,7 +3,7 @@
> # More details about systemd generator:
> #
http://www.freedesktop.org/wiki/Software/systemd/Generators/
>
> -. /usr/lib/kdump/kdump-lib.sh
> +. /lib/kdump/kdump-lib.sh
Fedora use /usr/lib by default, it is better to use /usr/lib
https://fedoraproject.org/wiki/Features/UsrMove
I went through the Fedora documentation. I agree to drop this.
Now, I am thinking if we should try to have kdump helper scripts
(all?) use /usr/lib instead of /lib everywhere.
Let me know your opinion on the same.
Regards,
Bhupesh