On Wed, Oct 26, 2022 at 03:24:43PM +0800, Coiby Xu wrote:
On Thu, Oct 20, 2022 at 02:55:10PM +0800, Lichen Liu wrote:
>Reviewed-by: Lichen Liu <lichliu(a)redhat.com>
Thanks for the review, patch merged!
Btw, I also changed the information regarding which keyslot will be used when
merging the patch,
- [[ $crypt_size -ne 0 ]] && echo -e "Encrypted kdump target requires
extra memory, assuming using the keyslot with minimun memory requirement\n"
+ [[ $crypt_size -ne 0 ]] && echo -e "Encrypted kdump target requires
extra memory, assuming using the keyslot with maximum memory requirement\n"
>
>On Mon, Sep 5, 2022 at 6:24 PM Coiby Xu <coxu(a)redhat.com> wrote:
>>
>>When there are multiple key slots, "kdumpctl estimate" uses the least
>>memory-consuming key slot. For example, when there are two memory slots
>>created with --pbkdf-memory=1048576 (1G) and --pbkdf-memory=524288 (512M),
>>"kdumpctl estimate" thinks the extra memory requirement is only 512M.
>>This will of course lead to OOM if the user uses the more
>>memory-consuming key slot. Fix it by sorting in reverse order.
>>
>>Fixes: e9e6a2c ("kdumpctl: Add kdumpctl estimate")
>>Signed-off-by: Coiby Xu <coxu(a)redhat.com>
>>---
>> kdumpctl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/kdumpctl b/kdumpctl
>>index 126ecb9..ee40d33 100755
>>--- a/kdumpctl
>>+++ b/kdumpctl
>>@@ -1241,7 +1241,7 @@ do_estimate()
>> for _dev in $(get_all_kdump_crypt_dev); do
>> _crypt_info=$(cryptsetup luksDump "/dev/block/$_dev")
>> [[ $(echo "$_crypt_info" | sed -n
"s/^Version:\s*\(.*\)/\1/p") == "2" ]] || continue
>>- for _mem in $(echo "$_crypt_info" | sed -n
"s/\sMemory:\s*\(.*\)/\1/p" | sort -n); do
>>+ for _mem in $(echo "$_crypt_info" | sed -n
"s/\sMemory:\s*\(.*\)/\1/p" | sort -n -r); do
>> crypt_size=$((crypt_size + _mem * 1024))
>> break
>> done
>>--
>>2.37.1
>>_______________________________________________
>>kexec mailing list -- kexec(a)lists.fedoraproject.org
>>To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
>>Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>>List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
>>List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
>>Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
>
--
Best regards,
Coiby
--
Best regards,
Coiby