On 12/17/14 at 04:40pm, Dave Young wrote:
> On 12/16/14 at 11:23am, Prarit Bhargava wrote:
>> On 11/17/2014 03:48 PM, Vivek Goyal wrote:
>>> On Mon, Nov 17, 2014 at 11:13:50AM -0500, Prarit Bhargava wrote:
>>>> With the inclusion of 'panic_on_warn',
>>>> and which is now staged in Andrew Morton's tree, we need to remove
>>>> 'panic_on_warn' from the 2nd kernel's cmdline. If it is
included it is
>>>> possible a non-fatal warning could panic the second kernel.
>>> This patch looks good to me. I think we can commit it once it show
>>> up in Linus tree.
>>> Acked-by: Vivek Goyal <vgoyal(a)redhat.com>
>> Dave and Vivek (who is on PTO),
>> The panic_on_warn patch has been committed into linux.git as
>> 9e3961a0979817c612b10b2da4f3045ec9faa779 ("kernel: add
> Prarit, rethink about it. How about do something in kexec-tools c code to remove
> panic_on_warn for kdump kernel boot? Since it is for not only rh distribution
> it will save time for other people who do not notice the changes.
We already have below:
1055 if (kexec_flags & KEXEC_ON_CRASH)
1056 remove_parameter(line, "crashkernel");
Ah -- I didn't even know about that. I'll look into this today and repost.
Thanks for the pointer Dave!