Re: [PATCH 8/8] unit tests: add check_config with with the default kdump.conf

[Philipp Rudo]

Hi Coiby,

On Tue,  1 Mar 2022 14:17:28 +0800
Coiby Xu  wrote:
> This test prevents the mistake of adding an option to kdump.conf
> without changing check_config as is the case with commit 73ced7f
> ("introduce the auto_reset_crashkernel option to kdump.conf").
> Signed-off-by: Coiby Xu
>
> spec/kdumpctl_general_spec.sh | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/spec/kdumpctl_general_spec.sh b/spec/kdumpctl_general_spec.sh
> index e7d057e..042ef53 100644
> --- a/spec/kdumpctl_general_spec.sh
> +++ b/spec/kdumpctl_general_spec.sh
> @@ -172,4 +172,12 @@ Describe 'kdumpctl'
>    	End
>    End
> Describe 'check_config()'
> It 'should be happy with the default kdump.conf'
> 	KDUMP_CONFIG_FILE=./kdump.conf
> 	When call check_config

The function was renamed to parse_config in the meantime.

Thanks
Philipp
> 	The status should be success
> End
> End
>
> End