On 11/13/15 at 04:52pm, Dave Young wrote:
On 10/30/15 at 09:32am, Baoquan He wrote:
> On 10/23/15 at 02:03pm, Dangyi Liu wrote:
> > Use KDUMP_COMMANDLINE_REMOVE config instead of hardcode them in
> > kdumpctl. System admins can also specify what to remove as they like.
> >
> > This patch also adds backward compatibility even if an old config is
> > used.
> >
> > Signed-off-by: Dangyi Liu <dliu(a)redhat.com>
>
>
> Dangyi,
>
> As I commented previously, it's not good to put
> crashkernel/panic_on_warn under /etc since it's 100% useless for kdump
> kernel or definitely break kdump kernel. Is there any other motivation
> to add this except it can please advanced users when they want to try
> these kernel paramenters in kdump kernel?
Bao,
Do you have objection to the original patch to hardcode "quiet" removing?
I think hardcode "quiet" stuffs is good, and am fine with introducing
"KDUMP_COMMANDLINE_REMOVE" option. For now we can hard code those
which absolutely need be removed and put those ambiguous kernel options
in KDUMP_COMMANDLINE_REMOVE.