On 09/23/13 at 02:59pm, Vivek Goyal wrote:
On Mon, Sep 02, 2013 at 03:44:15PM +0800, WANG Chao wrote:
> On 08/30/13 at 01:20pm, Vivek Goyal wrote:
> > On Thu, Aug 22, 2013 at 09:06:32AM +0800, Baoquan He wrote:
> > > Hi Wade,
> > >
> > > Thanks for your patch. I know high priority tasks need be handled
> > > firstly.
> > >
> > > Don't be discouraged. I will merge it with tiny adjusting.
> > >
> > Bao,
> > This path define strip_xyz() 2 times in two separate files. I think it
> > is high time we start thinking of intorducing a shared functions file
> > for kdump which various kdump scripts can share.
> > Adding duplicate code is bad.
> > Chao, you were planning to look into this. Did you make any progress?
> Last time I checked, I could only extract about 6 or 7 common functions
> without doing major change crossing the kdump source code.
I think that's a good start to create a file for shared functions.
> It looks like we do have common functions used by multiple file.
Where is that. We don't seem to have any file with common functions
which is included by others?
We don't have any file to share common functions.
> that's quite a small group. I don't know if it's worth it to have
> minority in a shared lib file and leave the majority still. What do you
I still think that we need to introduce a common function file. We might
start small but once we have a place holder, future common functions will
Only thing we need to make sure is that same functions should be usable
in both dracut context as well as mkdumprd context.
We might also need it in 2nd kernel.
I'll start working on this.