Re: [PATCH 0/5] makedumpfile re-enable mmap
On Wed, Jan 08, 2014 at 02:55:03PM +0800, WANG Chao wrote:
Hi,
I'd like to re-enable makedumpfile mmap(), since upstream patches are ready.
There are two commits that I want to backport:
1. makedumpfile: Fall back to read() when mmap() fails
2. makedumpfile: Add --non-mmap option to disable mmap() manually
#1 can be applied cleanly on top of our makedumpfile-1.5.4
#2 has conflicts, so I bring in two addtional patches. These two patches are trivial.
I think it's worth to backport #2 to have a switch between mmap and read. It
could be used as workaround when mmap has issues again.
v2 -> v1:
- fix upstream commit id [dyoung]
These patches look good to me.
Acked-by: Vivek Goyal <vgoyal(a)redhat.com>
Vivek
WANG Chao (5):
makedumpfile: Revert "makedumpfile: disable mmap"
makedumpfile: Assign non-printable value as short options
makedumpfile: Add help and man message for '--help'
makedumpfile: Add --non-mmap option to disable mmap() manually
makedumpfile: Fall back to read() when mmap() fails
...umpfile-Add-help-and-man-message-for-help.patch | 43 ++++
...-non-mmap-option-to-disable-mmap-manually.patch | 161 ++++++++++++++
...ssign-non-printable-value-as-short-option.patch | 244 +++++++++++++++++++++
...umpfile-Fall-back-to-read-when-mmap-fails.patch | 38 ++++
kexec-tools-2.0.4-makedumpfile-disable-mmap.patch | 36 ---
kexec-tools.spec | 11 +-
6 files changed, 494 insertions(+), 39 deletions(-)
create mode 100644
kexec-tools-2.0.4-makedumpfile-Add-help-and-man-message-for-help.patch
create mode 100644
kexec-tools-2.0.4-makedumpfile-Add-non-mmap-option-to-disable-mmap-manually.patch
create mode 100644
kexec-tools-2.0.4-makedumpfile-Assign-non-printable-value-as-short-option.patch
create mode 100644
kexec-tools-2.0.4-makedumpfile-Fall-back-to-read-when-mmap-fails.patch
delete mode 100644 kexec-tools-2.0.4-makedumpfile-disable-mmap.patch
--
1.8.4.2
_______________________________________________
kexec mailing list
kexec(a)lists.fedoraproject.org
https://lists.fedoraproject.org/mailman/listinfo/kexec