Re: [PATCH 1/2] Prefix reset-crashkernel-{for-installed_kernel,after-update} with underscore

[Lichen Liu]

Reviewed-by: Lichen Liu <lichliu(a)redhat.com&gt;

On Fri, Sep 16, 2022 at 6:27 PM Coiby Xu <coxu(a)redhat.com&gt; wrote:
>  Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2048690
>
>  To indicate they are for internal use only, underscore them.
>
>  Reported-by: rcheerla(a)redhat.com
>  Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt;
>  ---
>   92-crashkernel.install | 2 +-
>   kdumpctl               | 4 ++--
>   kexec-tools.spec       | 2 +-
>   3 files changed, 4 insertions(+), 4 deletions(-)
>
>  diff --git a/92-crashkernel.install b/92-crashkernel.install
>  index 1d67a133..19bd0784 100755
>  --- a/92-crashkernel.install
>  +++ b/92-crashkernel.install
>  @@ -7,7 +7,7 @@ KERNEL_IMAGE="$4"
>
>   case "$COMMAND" in
>   add)
>  -       kdumpctl reset-crashkernel-for-installed_kernel "$KERNEL_VERSION"
>  +       kdumpctl _reset-crashkernel-for-installed_kernel "$KERNEL_VERSION"
>          exit 0
>          ;;
>   esac
>  diff --git a/kdumpctl b/kdumpctl
>  index 0e37d36e..19febd53 100755
>  --- a/kdumpctl
>  +++ b/kdumpctl
>  @@ -1764,12 +1764,12 @@ main()
>                  shift
>                  reset_crashkernel "$@"
>                  ;;
>  -       reset-crashkernel-after-update)
>  +       _reset-crashkernel-after-update)
>                  if [[ $(kdump_get_conf_val auto_reset_crashkernel) != no ]]; then
>                          reset_crashkernel_after_update
>                  fi
>                  ;;
>  -       reset-crashkernel-for-installed_kernel)
>  +       _reset-crashkernel-for-installed_kernel)
>                  if [[ $(kdump_get_conf_val auto_reset_crashkernel) != no ]]; then
>                          reset_crashkernel_for_installed_kernel "$2"
>                  fi
>  diff --git a/kexec-tools.spec b/kexec-tools.spec
>  index ee43b13c..5f0e1b53 100644
>  --- a/kexec-tools.spec
>  +++ b/kexec-tools.spec
>  @@ -343,7 +343,7 @@ done
>   #  2. "[ $1 == 1 ]" in posttrans scriptlet means both install and upgrade.
> The
>   #     former case is used to set up crashkernel for osbuild
>   if [ ! -f /run/ostree-booted ] && [ $1 == 1 ]; then
>  -  kdumpctl reset-crashkernel-after-update
>  +  kdumpctl _reset-crashkernel-after-update
>     rm /tmp/old_default_crashkernel 2>/dev/null
>   %ifarch ppc64 ppc64le
>     rm /tmp/old_default_crashkernel_fadump 2>/dev/null
>  --
>  2.37.2
>  _______________________________________________
>  kexec mailing list -- kexec(a)lists.fedoraproject.org
>  To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]
>  Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue