On 10/10/14 at 02:41pm, Minfei Huang wrote:
On Oct 10, 2014, at 2:14 PM, Dave Young <dyoung(a)redhat.com> wrote:
> On 09/22/14 at 11:24am, Minfei Huang wrote:
>> If the grub kernel commandline is set to crashkernel=auto, it will not
>> expand the crashkernel=auto in the /proc/cmdline. It still says
>> crashkernel=auto.
>>
>> Using /sys to determines crashkernel actual size is confusing since
>> there is no unit of measure.
>>
>> Add a new command "kdumpctl showmem" to show the reserved memory
kindly.
>
> How about show the value in "kdumpctl status" output?
I think it is better. We can show the reserved memory like following:
[minfei@localhost kexec-tools]$ sudo systemctl stop kdump
[minfei@localhost kexec-tools]$ sudo kdumpctl status
Kdump is not operational
I think in this case, we'd better output how much memory we reserved as
well, as the following:
Kdump is not operational (Reserved memory 128M).
[minfei@localhost kexec-tools]$ sudo systemctl start kdump
[minfei@localhost kexec-tools]$ sudo kdumpctl status
Kdump is operational (Reserved memory 128MB)
>
>>
>> Signed-off-by: Minfei Huang <mhuang(a)redhat.com>
>> ---
>> kdumpctl | 16 +++++++++++++++-
>> 1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/kdumpctl b/kdumpctl
>> index 70d30fa..6f27669 100755
>> --- a/kdumpctl
>> +++ b/kdumpctl
>> @@ -526,6 +526,17 @@ propagate_ssh_key()
>> fi
>> }
>>
>> +show_reserved_mem()
>> +{
>> + MEM_RESERVED=$(cat /sys/kernel/kexec_crash_size)
>> + if [ $MEM_RESERVED -eq 0 ]
>> + then
>> + echo "No memory reserved for crash kernel."
>> + return
>> + fi
>> + echo "The kdump service reserved memory is `expr $MEM_RESERVED / 1024 /
1024`MB"
>> +}
>> +
>> is_fadump_capable()
>> {
>> # Check if firmware-assisted dump is enabled
>> @@ -899,8 +910,11 @@ main ()
>> propagate)
>> propagate_ssh_key
>> ;;
>> + showmem)
>> + show_reserved_mem
>> + ;;
>> *)
>> - echo $"Usage: $0 {start|stop|status|restart|propagate}"
>> + echo $"Usage: $0 {start|stop|status|restart|propagate|showmem}"
>> exit 1
>> esac
>> }
>> --
>> 1.8.3.1
>>
>> _______________________________________________
>> kexec mailing list
>> kexec(a)lists.fedoraproject.org
>>
https://lists.fedoraproject.org/mailman/listinfo/kexec
>>
>>
--
Minfei
_______________________________________________
kexec mailing list
kexec(a)lists.fedoraproject.org
https://lists.fedoraproject.org/mailman/listinfo/kexec