Re: [PATCH v2 0/7] Add support for unmounted dump target
On 05/12/2020 11:54 PM, Kairui Song wrote:
Currently kexec-tools always depend on dump target to be mounted,
which
caused some inconvenience for setup.
So for user configured target, allow kdump to start and build initramfs
even if target is not mounted.
Behavior is not changed for "path" based dump target config.
When a unmounted dump target is explcitely configured, mkdumprd will look
for corresponding mount info in fstab for the mount options, and
failback to use "defaults" as mount option.
Then mkdumprd will try to mount it and do basic checks on the device,
then umount it on exit.
NOTE: If there is a fstab entry but "noauto" option is not used, then
there must be some reason that the target device is not mounted,
mkdumprd will error out and ask user to double check.
Update from v1:
Rebase and add some document.
Kairui Song (7):
Add a is_mounted helper
Allow calling mkdumprd from kdumpctl even if targat not mounted
kdump-lib.sh: add fstab failback helper for getting mount info
User get_mount_info to replace findmnt calls
mkdumprd: generate usable kdump initramfs even target is not mounted
kexec-kdump-howto.txt: Add some format to the document
Update docs for the new noauto dump target support
kdump-lib-initramfs.sh | 23 ++-
kdump-lib.sh | 58 ++++---
kdumpctl | 9 +-
kexec-kdump-howto.txt | 363 ++++++++++++++++++++++++++---------------
mkdumprd | 130 +++++++++++----
5 files changed, 371 insertions(+), 212 deletions(-)
I think you can correct 7/7 in local repo, then
for this series,
Acked-by: Pingfan Liu <piliu(a)redhat.com>