On Thursday 17 November 2016 07:05 AM, Dave Young wrote:
>
> > get_kdump_confs()
> > {
> > - local config_opt config_val
> > + local config_opt config_val numcpu
> >
> > while read config_opt config_val;
> > do
> > @@ -73,6 +73,12 @@ get_kdump_confs()
> > esac
> > done < $KDUMP_CONF
> >
> > + if [[ "$CORE_COLLECTOR" =~ "makedumpfile" ]]; then
> > + if ! [[ $CORE_COLLECTOR =~ "--num-threads" ]]; then
> > + numcpu=$(grep -c '^processor' /proc/cpuinfo)
> > + CORE_COLLECTOR="$CORE_COLLECTOR --num-threads $numcpu"
> > + fi
Since we have the interface for user to change the makedumpfile
arguments so I'm not sure we should do it automaticlly here..
OK..I understood some concern while discussing at IRC, for example with
x86 intel cpus, num-threads should be 1 less than the number of oneline
cpus for better performance...performance at different filter level can
also vary(some time negatively) using num-threads. There can be some
other concern as well.
Therefore, I will do some more analysis before I send V2, or may be
tuning it manually in kdump.conf would be a better choice, and we do not
need any patch. Will come back.
~Pratyush