Hi Pingfan,
On Fri, 6 May 2022 16:29:28 +0800
Pingfan Liu <piliu(a)redhat.com> wrote:
On Thu, May 5, 2022 at 10:42 PM Philipp Rudo <prudo(a)redhat.com>
wrote:
>
> Hi Pingfan,
>
> On Thu, 5 May 2022 14:37:19 +0800
> Pingfan Liu <piliu(a)redhat.com> wrote:
>
> > s390x implements zlib/dfltcc dedicated instruction to improve
> > compression speed and ratio. Switching from 'makedumpfile -l' to
> > 'makedumpfile -c' to benifit from this feature.
> >
> > Signed-off-by: Pingfan Liu <piliu(a)redhat.com>
> > ---
> > v1 -> v2:
> > move 'sed' from %post to %build section
> > kexec-tools.spec | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/kexec-tools.spec b/kexec-tools.spec
> > index 6673000..1c4c0cf 100644
> > --- a/kexec-tools.spec
> > +++ b/kexec-tools.spec
> > @@ -144,6 +144,12 @@ autoreconf
> > %endif
> > --sbindir=/usr/sbin
> > rm -f kexec-tools.spec.in
> > +
> > +# s390 uses zlib/dfltcc as default to improve compression speed and ratio
> > +%ifarch s390x
> > +sed -i 's/makedumpfile -l/makedumpfile -c/' %{SOURCE8}
> > +%endif
> > +
> > # setup the docs
> > cp %{SOURCE10} .
> > cp %{SOURCE11} .
>
> v2 looks better and should work. But I'm wondering if it wouldn't be
> better to use a script that generates the config similar to what Kairui
> suggests for the sysconfig. My concern is that there are now two places
Not sure whether I catch your point.
For sysconfig, there are the following files:
kdump.sysconfig
kdump.sysconfig.aarch64
kdump.sysconfig.i386
kdump.sysconfig.ppc64
kdump.sysconfig.ppc64le
kdump.sysconfig.s390x
kdump.sysconfig.x86_64
Do you mean a dedicated kdump.conf.s390x ? And by that way, we can
avoid using a script that generates a config?
Kairui just posted his suggestion just recently [1]. It's still in
discussion and hasn't been merged, yet.
After some thinking I prefer to have one script that has the default
config in a here-doc at the beginning and then builds a sed script to
manipulate the default like Kairui suggested in [1]. At least with that
we have all the definitions of one config in a single place.
Thanks
Philipp
[1]
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.o...
Thanks,
Pingfan
> where kdump.conf is defined. So we always keep in mind to also check
> the spec file when we update kdump.conf. Otherwise we might introduce a
> bug that could easily be prevented if there is only one place to check.
>
> Thanks
> Philipp
>
_______________________________________________
kexec mailing list -- kexec(a)lists.fedoraproject.org
To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure