Hello Christos. Could you please make one more change. I should have
been more specific previously, sorry for that.
The thing is that devices labeled with "to_guest" are visible as tap
devices from host and as ordinary eth devices from inside the guest.
This applies to phase2 recipes changes in your another patchset.
See the proposal below ...
Fri, Oct 26, 2018 at 10:22:23AM CEST, csfakian(a)redhat.com wrote:
From: Christos Sfakianakis <csfakian(a)redhat.com>
Rename all devices that have "to_guest" label to tap[0-9] instead
of eth[0-9] to avoid confusion.
Signed-off-by: Christos Sfakianakis <csfakian(a)redhat.com>
---
.../VirtualBridgeVlanInGuestMirroredRecipe.py | 32 +++++++-------
.../ENRT/VirtualBridgeVlanInGuestRecipe.py | 16 +++----
.../VirtualBridgeVlanInHostMirroredRecipe.py | 44 +++++++++----------
.../ENRT/VirtualBridgeVlanInHostRecipe.py | 22 +++++-----
.../ENRT/VirtualBridgeVlansOverBondRecipe.py | 28 ++++++------
5 files changed, 71 insertions(+), 71 deletions(-)
diff --git a/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestMirroredRecipe.py
b/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestMirroredRecipe.py
index d349d5b..60a30fa 100644
--- a/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestMirroredRecipe.py
+++ b/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestMirroredRecipe.py
@@ -12,17 +12,17 @@ from lnst.Devices import BridgeDevice
class VirtualBridgeVlanInGuestMirroredRecipe(BaseEnrtRecipe):
host1 = HostReq()
host1.eth0 = DeviceReq(label="to_switch")
- host1.eth1 = DeviceReq(label="to_guest1")
+ host1.tap0 = DeviceReq(label="to_guest1")a
This is ok, host1 sees the guest's interface as tap device.
host2 = HostReq()
host2.eth0 = DeviceReq(label="to_switch")
- host2.eth1 = DeviceReq(label="to_guest2")
+ host2.tap0 = DeviceReq(label="to_guest2")
This is ok, host2 sees the guest's interface as tap device.
guest1 = HostReq()
- guest1.eth0 = DeviceReq(label="to_guest1")
+ guest1.tap0 = DeviceReq(label="to_guest1")
Here it should go like because from guest point of view it's an ethernet
device:
guest1.eth0 = DeviceReq(label="to_guest1")
guest2 = HostReq()
- guest2.eth0 = DeviceReq(label="to_guest2")
+ guest2.tap0 = DeviceReq(label="to_guest2")
Same here ^^^
>
> offload_combinations = Param(default=(
> dict(gro="on", gso="on", tso="on",
tx="on", rx="on"),