Re: [PATCH] Recipes.ENRT: move wait_tentative_ips to BaseEnrtRecipe

[Jan Tluka]

Fri, Apr 03, 2020 at 12:56:25PM CEST, jtluka(a)redhat.com wrote:
> This method is same in all of the recipes. There's no need to
> duplicate the code.
>
> Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
> ---
>  lnst/Recipes/ENRT/BaseEnrtRecipe.py                       | 8 ++++++++
>  lnst/Recipes/ENRT/BondRecipe.py                           | 8 --------
>  lnst/Recipes/ENRT/DoubleBondRecipe.py                     | 8 --------
>  lnst/Recipes/ENRT/DoubleTeamRecipe.py                     | 8 --------
>  lnst/Recipes/ENRT/IpsecEspAeadRecipe.py                   | 8 --------
>  lnst/Recipes/ENRT/IpsecEspAhCompRecipe.py                 | 8 --------
>  lnst/Recipes/ENRT/NoVirtOvsVxlanRecipe.py                 | 8 --------
>  lnst/Recipes/ENRT/ShortLivedConnectionsRecipe.py          | 8 --------
>  lnst/Recipes/ENRT/SimpleMacsecRecipe.py                   | 8 --------
>  lnst/Recipes/ENRT/SimpleNetworkRecipe.py                  | 8 --------
>  lnst/Recipes/ENRT/TeamRecipe.py                           | 8 --------
>  lnst/Recipes/ENRT/TeamVsBondRecipe.py                     | 8 --------
>  lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py                   | 8 --------
>  .../ENRT/VirtualBridgeVlanInGuestMirroredRecipe.py        | 8 --------
>  lnst/Recipes/ENRT/VirtualBridgeVlanInGuestRecipe.py       | 8 --------
>  .../Recipes/ENRT/VirtualBridgeVlanInHostMirroredRecipe.py | 8 --------
>  lnst/Recipes/ENRT/VirtualBridgeVlanInHostRecipe.py        | 8 --------
>  lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py     | 8 --------
>  .../ENRT/VirtualOvsBridgeVlanInGuestMirroredRecipe.py     | 8 --------
>  lnst/Recipes/ENRT/VirtualOvsBridgeVlanInGuestRecipe.py    | 8 --------
>  .../ENRT/VirtualOvsBridgeVlanInHostMirroredRecipe.py      | 8 --------
>  lnst/Recipes/ENRT/VirtualOvsBridgeVlanInHostRecipe.py     | 8 --------
>  lnst/Recipes/ENRT/VirtualOvsBridgeVlansOverBondRecipe.py  | 8 --------
>  lnst/Recipes/ENRT/VlansOverBondRecipe.py                  | 8 --------
>  lnst/Recipes/ENRT/VlansOverTeamRecipe.py                  | 8 --------
>  lnst/Recipes/ENRT/VlansRecipe.py                          | 8 --------
>  lnst/Recipes/ENRT/VxlanMulticastRecipe.py                 | 8 --------
>  lnst/Recipes/ENRT/VxlanRemoteRecipe.py                    | 8 --------
>  28 files changed, 8 insertions(+), 216 deletions(-)
>
> diff --git a/lnst/Recipes/ENRT/BaseEnrtRecipe.py b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
> index bd26cbe..cc8af57 100644
> --- a/lnst/Recipes/ENRT/BaseEnrtRecipe.py
> +++ b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
> @@ -241,6 +241,14 @@ class BaseEnrtRecipe(BaseSubConfigMixin, PingTestAndEvaluate,
> PerfRecipe):
>      def net_perf_evaluators(self):
>          return [NonzeroFlowEvaluator()]
>  
> +    def wait_tentative_ips(self, devices):
> +        def condition():
> +            return all(
> +                [not ip.is_tentative for dev in devices for ip in dev.ips]
> +            )
> +
> +        self.ctl.wait_for_condition(condition, timeout=5)
> +
>      def _create_reverse_flow(self, flow):
>          rev_flow = PerfFlow(
>                      type = flow.type,
> diff --git a/lnst/Recipes/ENRT/BondRecipe.py b/lnst/Recipes/ENRT/BondRecipe.py
> index 466684c..6ef40db 100644
> --- a/lnst/Recipes/ENRT/BondRecipe.py
> +++ b/lnst/Recipes/ENRT/BondRecipe.py
> @@ -89,14 +89,6 @@ class BondRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.host1.bond0, self.matched.host2.eth0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.bond0, self.matched.host2.eth0]
> diff --git a/lnst/Recipes/ENRT/DoubleBondRecipe.py
> b/lnst/Recipes/ENRT/DoubleBondRecipe.py
> index 25f10ac..73a7222 100644
> --- a/lnst/Recipes/ENRT/DoubleBondRecipe.py
> +++ b/lnst/Recipes/ENRT/DoubleBondRecipe.py
> @@ -96,14 +96,6 @@ class DoubleBondRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.host1.bond0, self.matched.host2.bond0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.bond0, self.matched.host2.bond0]
> diff --git a/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> b/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> index 82762af..12f56fc 100644
> --- a/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> +++ b/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> @@ -97,14 +97,6 @@ class DoubleTeamRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
>          return [(self.matched.host1.team0, self.matched.host2.team0),
>              (self.matched.host2.team0, self.matched.host1.team0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.team0, self.matched.host2.team0]
> diff --git a/lnst/Recipes/ENRT/IpsecEspAeadRecipe.py
> b/lnst/Recipes/ENRT/IpsecEspAeadRecipe.py
> index 0daf30f..845796c 100644
> --- a/lnst/Recipes/ENRT/IpsecEspAeadRecipe.py
> +++ b/lnst/Recipes/ENRT/IpsecEspAeadRecipe.py
> @@ -79,14 +79,6 @@ class IpsecEspAeadRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe,
>  
>          super().test_wide_deconfiguration(config)
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      def generate_sub_configurations(self, config):
>          ipsec_mode = self.params.ipsec_mode
>          spi_values = self.spi_values
> diff --git a/lnst/Recipes/ENRT/IpsecEspAhCompRecipe.py
> b/lnst/Recipes/ENRT/IpsecEspAhCompRecipe.py
> index 60dc2b9..a788143 100644
> --- a/lnst/Recipes/ENRT/IpsecEspAhCompRecipe.py
> +++ b/lnst/Recipes/ENRT/IpsecEspAhCompRecipe.py
> @@ -80,14 +80,6 @@ class IpsecEspAhCompRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe,
>  
>          super().test_wide_deconfiguration(config)
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      def generate_sub_configurations(self, config):
>          ipsec_mode = self.params.ipsec_mode
>          spi_values = self.spi_values
> diff --git a/lnst/Recipes/ENRT/NoVirtOvsVxlanRecipe.py
> b/lnst/Recipes/ENRT/NoVirtOvsVxlanRecipe.py
> index 3fbb384..92dc3a1 100644
> --- a/lnst/Recipes/ENRT/NoVirtOvsVxlanRecipe.py
> +++ b/lnst/Recipes/ENRT/NoVirtOvsVxlanRecipe.py
> @@ -98,14 +98,6 @@ class NoVirtOvsVxlanRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe):
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.host1.int0, self.matched.host2.int0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def mtu_hw_config_dev_list(self):
>          return [self.matched.host1.int0, self.matched.host2.int0]
> diff --git a/lnst/Recipes/ENRT/ShortLivedConnectionsRecipe.py
> b/lnst/Recipes/ENRT/ShortLivedConnectionsRecipe.py
> index 0bc4b51..85c768a 100644
> --- a/lnst/Recipes/ENRT/ShortLivedConnectionsRecipe.py
> +++ b/lnst/Recipes/ENRT/ShortLivedConnectionsRecipe.py
> @@ -54,14 +54,6 @@ class ShortLivedConnectionsRecipe(CommonHWSubConfigMixin,
> BaseEnrtRecipe):
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.host1.eth0, self.matched.host2.eth0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def mtu_hw_config_dev_list(self):
>          return [self.matched.host1.eth0, self.matched.host2.eth0]
> diff --git a/lnst/Recipes/ENRT/SimpleMacsecRecipe.py
> b/lnst/Recipes/ENRT/SimpleMacsecRecipe.py
> index 131a62a..92926b0 100644
> --- a/lnst/Recipes/ENRT/SimpleMacsecRecipe.py
> +++ b/lnst/Recipes/ENRT/SimpleMacsecRecipe.py
> @@ -70,14 +70,6 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe):
>  
>          super().test_wide_deconfiguration(config)
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      def generate_sub_configurations(self, config):
>          for subconf in ConfMixin.generate_sub_configurations(self, config):
>              for encryption in self.macsec_settings:
> diff --git a/lnst/Recipes/ENRT/SimpleNetworkRecipe.py
> b/lnst/Recipes/ENRT/SimpleNetworkRecipe.py
> index 06893f6..2f2a63a 100644
> --- a/lnst/Recipes/ENRT/SimpleNetworkRecipe.py
> +++ b/lnst/Recipes/ENRT/SimpleNetworkRecipe.py
> @@ -62,14 +62,6 @@ class SimpleNetworkRecipe(
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.host1.eth0, self.matched.host2.eth0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def no_pause_frames_dev_list(self):
>          return [self.matched.host1.eth0, self.matched.host2.eth0]
> diff --git a/lnst/Recipes/ENRT/TeamRecipe.py b/lnst/Recipes/ENRT/TeamRecipe.py
> index 3a30b01..e083b90 100644
> --- a/lnst/Recipes/ENRT/TeamRecipe.py
> +++ b/lnst/Recipes/ENRT/TeamRecipe.py
> @@ -92,14 +92,6 @@ class TeamRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
>          return [(self.matched.host1.team0, self.matched.host2.eth0),
>              (self.matched.host2.eth0, self.matched.host1.team0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.team0, self.matched.host2.eth0]
> diff --git a/lnst/Recipes/ENRT/TeamVsBondRecipe.py
> b/lnst/Recipes/ENRT/TeamVsBondRecipe.py
> index 4b66199..8971bc2 100644
> --- a/lnst/Recipes/ENRT/TeamVsBondRecipe.py
> +++ b/lnst/Recipes/ENRT/TeamVsBondRecipe.py
> @@ -114,14 +114,6 @@ class TeamVsBondRecipe(CommonHWSubConfigMixin,
> OffloadSubConfigMixin,
>          return [(self.matched.host1.team0, self.matched.host2.bond0),
>              (self.matched.host2.bond0, self.matched.host1.team0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.team0, self.matched.host2.bond0]
> diff --git a/lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py
> b/lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py
> index 44391b7..9e9c0c5 100644
> --- a/lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py
> +++ b/lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py
> @@ -141,14 +141,6 @@ class VirtOvsVxlanRecipe(VlanPingEvaluatorMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.guest1.eth0, self.matched.guest3.eth0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def mtu_hw_config_dev_list(self):
>          return [self.matched.guest1.eth0, self.matched.guest2.eth0,
> diff --git a/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestMirroredRecipe.py
> b/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestMirroredRecipe.py
> index 13eacd0..494e79d 100644
> --- a/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestMirroredRecipe.py
> +++ b/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestMirroredRecipe.py
> @@ -127,14 +127,6 @@ class VirtualBridgeVlanInGuestMirroredRecipe(CommonHWSubConfigMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.guest1.vlan0, self.matched.guest2.vlan0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.eth0, self.matched.host2.eth0,
> diff --git a/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestRecipe.py
> b/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestRecipe.py
> index d557dd5..65732bb 100644
> --- a/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestRecipe.py
> +++ b/lnst/Recipes/ENRT/VirtualBridgeVlanInGuestRecipe.py
> @@ -112,14 +112,6 @@ class VirtualBridgeVlanInGuestRecipe(CommonHWSubConfigMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.guest1.vlan0, self.matched.host2.vlan0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.eth0, self.matched.host2.eth0,
> diff --git a/lnst/Recipes/ENRT/VirtualBridgeVlanInHostMirroredRecipe.py
> b/lnst/Recipes/ENRT/VirtualBridgeVlanInHostMirroredRecipe.py
> index 52d88de..f17228b 100644
> --- a/lnst/Recipes/ENRT/VirtualBridgeVlanInHostMirroredRecipe.py
> +++ b/lnst/Recipes/ENRT/VirtualBridgeVlanInHostMirroredRecipe.py
> @@ -126,14 +126,6 @@ class VirtualBridgeVlanInHostMirroredRecipe(CommonHWSubConfigMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.guest1.eth0, self.matched.guest2.eth0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.eth0, self.matched.host2.eth0,
> diff --git a/lnst/Recipes/ENRT/VirtualBridgeVlanInHostRecipe.py
> b/lnst/Recipes/ENRT/VirtualBridgeVlanInHostRecipe.py
> index 728cf06..d94ed70 100644
> --- a/lnst/Recipes/ENRT/VirtualBridgeVlanInHostRecipe.py
> +++ b/lnst/Recipes/ENRT/VirtualBridgeVlanInHostRecipe.py
> @@ -110,14 +110,6 @@ class VirtualBridgeVlanInHostRecipe(CommonHWSubConfigMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.guest1.eth0, self.matched.host2.vlan0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.eth0, self.matched.host2.eth0,
> diff --git a/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
> b/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
> index 21b3781..eb29fdc 100644
> --- a/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
> +++ b/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
> @@ -188,14 +188,6 @@ class VirtualBridgeVlansOverBondRecipe(VlanPingEvaluatorMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.guest1.eth0, self.matched.guest3.eth0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          host1, host2, guest1, guest2, guest3, guest4 = (self.matched.host1,
> diff --git a/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInGuestMirroredRecipe.py
> b/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInGuestMirroredRecipe.py
> index 05245c0..daba9f4 100644
> --- a/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInGuestMirroredRecipe.py
> +++ b/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInGuestMirroredRecipe.py
> @@ -121,14 +121,6 @@ class
> VirtualOvsBridgeVlanInGuestMirroredRecipe(CommonHWSubConfigMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.guest1.vlan0, self.matched.guest2.vlan0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.eth0, self.matched.host2.eth0,
> diff --git a/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInGuestRecipe.py
> b/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInGuestRecipe.py
> index 5ca44f8..7137600 100644
> --- a/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInGuestRecipe.py
> +++ b/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInGuestRecipe.py
> @@ -105,14 +105,6 @@ class VirtualOvsBridgeVlanInGuestRecipe(CommonHWSubConfigMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.host2.vlan0, self.matched.guest1.vlan0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.eth0, self.matched.host2.eth0,
> diff --git a/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInHostMirroredRecipe.py
> b/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInHostMirroredRecipe.py
> index b85350a..5e68862 100644
> --- a/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInHostMirroredRecipe.py
> +++ b/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInHostMirroredRecipe.py
> @@ -103,14 +103,6 @@ class
> VirtualOvsBridgeVlanInHostMirroredRecipe(CommonHWSubConfigMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.guest1.eth0, self.matched.guest2.eth0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.eth0, self.matched.host2.eth0,
> diff --git a/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInHostRecipe.py
> b/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInHostRecipe.py
> index 93f2c28..3355cdb 100644
> --- a/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInHostRecipe.py
> +++ b/lnst/Recipes/ENRT/VirtualOvsBridgeVlanInHostRecipe.py
> @@ -96,14 +96,6 @@ class VirtualOvsBridgeVlanInHostRecipe(CommonHWSubConfigMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.guest1.eth0, self.matched.host2.vlan0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.eth0, self.matched.host2.eth0,
> diff --git a/lnst/Recipes/ENRT/VirtualOvsBridgeVlansOverBondRecipe.py
> b/lnst/Recipes/ENRT/VirtualOvsBridgeVlansOverBondRecipe.py
> index d6a7d35..b1ace76 100644
> --- a/lnst/Recipes/ENRT/VirtualOvsBridgeVlansOverBondRecipe.py
> +++ b/lnst/Recipes/ENRT/VirtualOvsBridgeVlansOverBondRecipe.py
> @@ -157,14 +157,6 @@ class VirtualOvsBridgeVlansOverBondRecipe(VlanPingEvaluatorMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.guest1.eth0, self.matched.guest3.eth0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          host1, host2, guest1, guest2, guest3, guest4 = (self.matched.host1,
> diff --git a/lnst/Recipes/ENRT/VlansOverBondRecipe.py
> b/lnst/Recipes/ENRT/VlansOverBondRecipe.py
> index dc59432..45c3e18 100644
> --- a/lnst/Recipes/ENRT/VlansOverBondRecipe.py
> +++ b/lnst/Recipes/ENRT/VlansOverBondRecipe.py
> @@ -139,14 +139,6 @@ class VlansOverBondRecipe(VlanPingEvaluatorMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.host1.vlan0, self.matched.host2.vlan0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          host1, host2 = self.matched.host1, self.matched.host2
> diff --git a/lnst/Recipes/ENRT/VlansOverTeamRecipe.py
> b/lnst/Recipes/ENRT/VlansOverTeamRecipe.py
> index 1c44266..5ef430b 100644
> --- a/lnst/Recipes/ENRT/VlansOverTeamRecipe.py
> +++ b/lnst/Recipes/ENRT/VlansOverTeamRecipe.py
> @@ -137,14 +137,6 @@ class VlansOverTeamRecipe(VlanPingEvaluatorMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.host1.vlan0, self.matched.host2.vlan0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          host1, host2 = self.matched.host1, self.matched.host2
> diff --git a/lnst/Recipes/ENRT/VlansRecipe.py b/lnst/Recipes/ENRT/VlansRecipe.py
> index b18ec15..e6cf599 100644
> --- a/lnst/Recipes/ENRT/VlansRecipe.py
> +++ b/lnst/Recipes/ENRT/VlansRecipe.py
> @@ -111,14 +111,6 @@ class VlansRecipe(VlanPingEvaluatorMixin,
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.host1.vlan0, self.matched.host2.vlan0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def offload_nics(self):
>          return [self.matched.host1.eth0, self.matched.host2.eth0]
> diff --git a/lnst/Recipes/ENRT/VxlanMulticastRecipe.py
> b/lnst/Recipes/ENRT/VxlanMulticastRecipe.py
> index 235e64e..f6eec48 100644
> --- a/lnst/Recipes/ENRT/VxlanMulticastRecipe.py
> +++ b/lnst/Recipes/ENRT/VxlanMulticastRecipe.py
> @@ -110,14 +110,6 @@ class VxlanMulticastRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe):
>              self.matched.guest1)
>          return [(self.matched.host1.vxlan0, self.matched.host2.vxlan0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def mtu_hw_config_dev_list(self):
>          host1, host2, guest1 = (self.matched.host1, self.matched.host2,
> diff --git a/lnst/Recipes/ENRT/VxlanRemoteRecipe.py
> b/lnst/Recipes/ENRT/VxlanRemoteRecipe.py
> index 4978b6d..465fdc1 100644
> --- a/lnst/Recipes/ENRT/VxlanRemoteRecipe.py
> +++ b/lnst/Recipes/ENRT/VxlanRemoteRecipe.py
> @@ -90,14 +90,6 @@ class VxlanRemoteRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe):
>      def generate_perf_endpoints(self, config):
>          return [(self.matched.host1.vxlan0, self.matched.host2.vxlan0)]
>  
> -    def wait_tentative_ips(self, devices):
> -        def condition():
> -            return all(
> -                [not ip.is_tentative for dev in devices for ip in dev.ips]
> -            )
> -
> -        self.ctl.wait_for_condition(condition, timeout=5)
> -
>      @property
>      def mtu_hw_config_dev_list(self):
>          return [self.matched.host1.vxlan0, self.matched.host2.vxlan0]
> -- 
> 2.21.1
> _______________________________________________
> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...
Pushed,

-Jan