Thu, Oct 01, 2015 at 11:46:06AM CEST, olichtne(a)redhat.com wrote:
On Thu, Oct 01, 2015 at 11:29:02AM +0200, Jiri Prochazka wrote:
> Why we don't want to print the line at the end of the output?
>
I don't really care where it's printed, I just thought it could be a
good idea to print this information directly from the LoggingCtl class
instead of from lnst-ctl.
-Ondrej
I agree. I think it messes lnst-ctl this way.
> 2015-10-01 11:09 GMT+02:00 Ondrej Lichtner <olichtne(a)redhat.com>:
>
> > On Thu, Oct 01, 2015 at 10:20:02AM +0200, Jan Tluka wrote:
> > > Thu, Oct 01, 2015 at 09:35:42AM CEST, jprochaz(a)redhat.com wrote:
> > > >This may come in handy for user so he can immediately find correct log
> > dir
> > > >
> > > >Closes issue #140
> > > >
> > > >Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com>
> > > >---
> > > > lnst-ctl | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > >diff --git a/lnst-ctl b/lnst-ctl
> > > >index 947f3ad..d92eaed 100755
> > > >--- a/lnst-ctl
> > > >+++ b/lnst-ctl
> > > >@@ -333,6 +333,7 @@ def main():
> > > > log_ctl.set_recipe("", clean=False)
> > > >
> > > > res_serializer.print_summary()
> > > >+ logging.info("Saving logs to: %s" % log_ctl.log_folder)
> > > >
> > > > if result_path:
> > > > result_path = os.path.expanduser(result_path)
> > > >--
> > > >2.4.3
> > > >
> > > >_______________________________________________
> > > >LNST-developers mailing list
> > > >LNST-developers(a)lists.fedorahosted.org
> > > >https://lists.fedorahosted.org/mailman/listinfo/lnst-developers
> > >
> > > Either this should be printed right after creating LoggingCtl,
> > > log_ctl = LoggingCtl(debug,
> > > log_dir=lnst_config.get_option('environment',
> > 'log_dir'),
> > > log_subdir=date, colours=coloured_output)
> > >
> > > or it should say something like "Logs saved to:" at this place.
Since
> > > the subject says print this at the end I'd change the wording.
> > >
> > > Otherwise ack.
> >
> > Or you could just modify the LoggingCtl class to print out the log file
> > path autmatically when it's being created.
> >
> > -Ondrej
> >
>
>
>
> --
> Best regards,
>
> Jiri Prochazka
> LNST Developer
> |
www.lnst-project.org
>
> +420 532 294 633 | jprochaz(a)redhat.com
> Red Hat Czech | Purkyňova 71/99, 612 00 Brno