Re: [PATCH v2] TestModule, Recipe: add Netperf test module and example

[Jan Tluka]

Mon, Oct 23, 2017 at 06:21:58PM CEST, jprochaz(a)redhat.com wrote:
> Hi Kamil,
>
> comments inline.
>
> 2017-10-22 14:56 GMT+02:00 Kamil Jerabek <kjerabek(a)redhat.com&gt;:
>
> > This commit adds Netperf module to new lnst version. This is recreated
> > Netperf module. There is used new design which splits one old Netperf
> > class,
> > that contains implementation for client and server in one class, into two
> > classes Netserver and Netperf.
> >
> > This patch also includes expansion of example recipes/examples/python_
> > recipe.py.
> > It now contains also example Netperf module usage.
> >
> > v2 changes:
> >   * refactorization of logical structures and parameters
> >
> > Signed-off-by: Kamil Jerabek <kjerabek(a)redhat.com&gt;
> > ---
> >  lnst/Tests/Netperf.py             | 567 ++++++++++++++++++++++++++++++
> > ++++++++
> >  recipes/examples/python_recipe.py |  15 +
> >  2 files changed, 582 insertions(+)
> >  create mode 100644 lnst/Tests/Netperf.py
> >
> > diff --git a/lnst/Tests/Netperf.py b/lnst/Tests/Netperf.py
> > new file mode 100644
> > index 0000000..aca34e0
> > --- /dev/null
> > +++ b/lnst/Tests/Netperf.py
> > @@ -0,0 +1,567 @@
> > +import logging
> > +import errno
> > +import re
> > +from lnst.Common.Parameters import IntParam, IpParam, StrParam, Param
> > +from lnst.Common.TestModule import BaseTestModule, TestModuleError
> > +from lnst.Common.ShellProcess import ShellProcess
> > +from lnst.Common.ExecCmd import exec_cmd
> >
>
> ​imported but not used​
>  
Hi Kamil, I believe that Jiri found these with pylint tool.

It's a good practice to run the code through some validation tool. For
example:

python -m py_compile $FILE
pylint -E --disable=E0611,E1101,E1002 $FILE

-Jan