Re: [PATCH 4/4] Devices.OvsBridge: use ovs-vsctl list to get ovs bridge ports

[Ondrej Lichtner]

On Wed, Apr 01, 2020 at 12:07:32PM +0200, Jan Tluka wrote:
>  This is an additional patch that removes incorrect reference to
>  internal ports. The property internal_ports is removed and
>  ports with internal interfaces are now returned in property ports.
>  
>  The patch also fixes an issue with OvS 2.13 that changed
>  the output format of 'ovs-vsctl show' that was used to get
>  information about the ovs bridge ports. To be more future proof
>  the json output of 'ovs-vsctl list ports' is used instead.
>  
>  Since tunnels are also ports, the property tunnels reuses the ports
>  property and filters out the relevant ports.
>  
>  Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
>  ---
>   lnst/Devices/OvsBridgeDevice.py           | 125 +++++++++++-----------
>   lnst/Recipes/ENRT/NoVirtOvsVxlanRecipe.py |   4 +-
>   2 files changed, 66 insertions(+), 63 deletions(-)
>  
>  diff --git a/lnst/Devices/OvsBridgeDevice.py b/lnst/Devices/OvsBridgeDevice.py
>  index 28d786bb..fbe31b2c 100644
>  --- a/lnst/Devices/OvsBridgeDevice.py
>  +++ b/lnst/Devices/OvsBridgeDevice.py
>  @@ -12,6 +12,7 @@ olichtne(a)redhat.com (Ondrej Lichtner)
>   
>   import re
>   import pprint
>  +import json 
I think this import is unused.

Other than that I have no other comments to the patchset.

-Ondrej