2016-05-17 12:05 GMT+02:00 Jan Tluka <jtluka(a)redhat.com>:
Fri, Apr 22, 2016 at 10:52:14AM CEST, jprochaz(a)redhat.com wrote:
>it's more readable this way
>
>Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com>
>---
> lnst/Controller/NetTestController.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lnst/Controller/NetTestController.py
b/lnst/Controller/NetTestController.py
>index c921cc7..149fe66 100644
>--- a/lnst/Controller/NetTestController.py
>+++ b/lnst/Controller/NetTestController.py
>@@ -540,7 +540,7 @@ class NetTestController:
> #restore resource table
> self._resource_table = res_table_bkp
>
>- return module.ctl._result
>+ return Task.ctl._result
>
> def _run_command(self, command):
> logging.info("Executing command: [%s]", str_command(command))
IMO it's not. module variable represents the loaded python task and we return
the result of this particular task. I understand that both are correct
but this at least keeps the idea that we return the result of the loaded
task.
Please, Ondrej, what do you think?