Re: [PATCH] InterfaceAPI: Configure IP addresses following reset()

[Ondrej Lichtner]

On Sun, Oct 09, 2016 at 10:43:06PM +0300, idosch(a)idosch.org wrote:
>  From: Ido Schimmel <idosch(a)mellanox.com&gt;
>  
>  Up until commit 82f606fb169e ("{Net, Nm}ConfigDevice: split up() into
>  up+address_setup") up() used to both set the admin state of an interface
>  and configure it with IP address(es). However, the mentioned commit
>  split up() into up() and address_setup() and introduced a regression in
>  sections of code where up() isn't followed by address_setup().
>  
>  Fix this by following the call to up() with a call to address_setup() in
>  reset(), which seems to be the only place where this was missed.
>  
>  Fixes: 82f606fb169e ("{Net, Nm}ConfigDevice: split up() into
> up+address_setup")
>  Signed-off-by: Ido Schimmel <idosch(a)mellanox.com&gt;
>  ---
>  Tested with three recipes from recipes/switchdev that used to fail
>  before the patch.
>  ---
>   lnst/Controller/Task.py | 2 ++
>   1 file changed, 2 insertions(+)
>  
>  diff --git a/lnst/Controller/Task.py b/lnst/Controller/Task.py
>  index 84091af..6cbb165 100644
>  --- a/lnst/Controller/Task.py
>  +++ b/lnst/Controller/Task.py
>  @@ -617,6 +617,7 @@ class InterfaceAPI(object):
>           return self._if.get_netns()
>   
>       def reset(self, ip=None, netns=None):
>  +        self._if.address_cleanup()
>           self._if.down()
>           self._if.deconfigure()
>   
>  @@ -628,6 +629,7 @@ class InterfaceAPI(object):
>   
>           self._if.configure()
>           self._if.up()
>  +        self._if.address_setup()
>   
>       def set_addresses(self, ips):
>           self._if.set_addresses(ips)
>  -- 
>  2.7.4
>  _______________________________________________
>  LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
>  To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org 
pushed, thanks

-Ondrej