Re: [PATCH 0/2] Fixes to remove tcp_crr server side stats
On Thu, Apr 01, 2021 at 03:13:35PM -0400, pgagne(a)redhat.com wrote:
From: Perry Gagne <pgagne(a)redhat.com>
We decided to ignore tcp_crr stats for now due to a few reasons:
1. It was removed from neper upstream due to memory issues
2. The resulting LRC files where big
3. We were probably not caluclating stats in the first place in the crr
case
4. Neper's stats collection probably needs work to properly collect
stats.
For now we decided to record the server side stats as PerfIntervals of
0.
These patches contain some things to enable that.
Perry Gagne (2):
Utils.py: Added 3.6 backport of contextlib.nullcontext
NeperFlowMeasurement.py: Don't collect tcp_crr server side metric
lnst/Common/Utils.py | 25 ++++++++++++++++
.../Perf/Measurements/NeperFlowMeasurement.py | 8 +++++
lnst/Tests/Neper.py | 29 ++++++++++++++-----
3 files changed, 54 insertions(+), 8 deletions(-)
--
2.30.2
_______________________________________________
LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedora...
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
after discussion in a videocall we agreed that the remaining issue with
adding the nullcontext is mostly a cosmetic one and we can merge this.
With that I have pushed the patchset to the upstream master.
-Ondrej