[fedora-medical] packaging of gnumed-server

[Sebastian Hilbert]

Came across this bug again.

https://bugzilla.redhat.com/show_bug.cgi?id=669146

Comments below.

> Review: 
> [+] OK
> [-] NA
> [X] issue 
> X Package is a GUI app and has a .desktop file 
? Since when :-) If there is a desktop file we can remove it. This is not a gui app

> X Package owns all the directories it creates.
> The directories here are not owned by the package:
> %doc %{_defaultdocdir}/%{name}/*
> %{_sharedstatedir}/%{name}/* 
> You'll either have to use %dir %{_defaultdocdir}/%{name} 
> or simply 
> %doc %{_defaultdocdir}/%{name} 
So I guess this can be fixed ?

> gnumed-server.noarch: W: no-manual-page-for-binary
> gm-restore_database
> gnumed-server.noarch: W: no-manual-page-for-binary gm-zip+sign_backups
> gnumed-server.noarch: W: no-manual-page-for-binary gm-move_backups_offsite
> gnumed-server.noarch: W: no-manual-page-for-binary gm-restore_data 
True.

> /home/ankur/rpmbuild/SPECS/gnumed-server.spec: W: invalid-url
> Source0:
> http://www.gnumed.de/downloads/server/v14/gnumed-server.14.7.tgz HTTP Error
> 404: Not Found 
Maybe the server was down. Anyway I would like you to try version 15.4 of gnumed-server.

> gnumed-server.src: W: invalid-url Source0:
> http://www.gnumed.de/downloads/server/v14/gnumed-server.14.7.tgz HTTP Error
> 404: Not Found
> 2 packages and 1 specfiles checked; 0 errors, 6 warnings. 
Same here.


> SHOULD Items: 
Issues:

> 1. Some of the files show a GPL license (not a v2). This needs to be
> added to
> the spec. A copy of the v1 license should also be included in the package.  
@ Karsten. We could make this go away by licensing these files as GPL2, right ?

> 3. The package is a GUI tool right? In that case a desktop file must
> be added
> to the package as described here 
no it is not

> 4. Doesn't the package require Python? I don't see it in the
> Requires. Please
> check on this.  
It actually depends on 
 python-psycopg2 (>= 2.0.8) 
Python-Module for PostgreSQL 
which should nicely pull in python

> 5. I haven't been able to check the functioning (yet). 
you should :-)

> 6. Please check the other issues outlined above too (ownership etc.)
see comments

I would appreciate if the issues could be checked and if the bug could be 
updated.

Please let us (GNUmed) know if there are any issues you want us to fix 
upstream.

Sebastian