On April 19, 2013, 4:27 p.m., Tim Flink wrote:
sass/app.scss, line 37 http://reviewboard-tflink.rhcloud.com/r/18/diff/1/?file=243#file243line37
What's the advantage to greying this out instead of using the link colors that we're using elsewhere in the app?
Initially I thought that the link is not that important information so I greyed the link out. On second thought, let's make it consistent. Fixed.
On April 19, 2013, 4:27 p.m., Tim Flink wrote:
blockerbugs/templates/index.html, line 84 http://reviewboard-tflink.rhcloud.com/r/18/diff/1/?file=242#file242line84
How about something like: "This application is open source! Get the code (with embedded link to cgit) or look at development plans (with link to fedora-qa trac report 10)"?
Thanks, fixed.
On April 19, 2013, 4:27 p.m., Tim Flink wrote:
blockerbugs/templates/index.html, line 80 http://reviewboard-tflink.rhcloud.com/r/18/diff/1/?file=242#file242line80
Why limit this to just the index page instead of adding it to the global footer?
Agreed, fixed.
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/#review24 -----------------------------------------------------------
On April 22, 2013, 8:47 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/
(Updated April 22, 2013, 8:47 a.m.)
Review request for blockerbugs.
Bugs: 343 https://fedorahosted.org/fedora-qa/ticket/343
Repository: blockerbugs
Description
This is maybe trivial to have a review for but two things might be discussed:
- do we want to show the link just on index or on all pages?
- is the wording of the link ok?
Diffs
blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 blockerbugs/templates/index.html 088962bfcb16c3f0d163366f2235fc557e0d45dc
Diff: http://reviewboard-tflink.rhcloud.com/r/18/diff/
Testing
Thanks,
Martin Krizek