[Fedora-spins] [spin-kickstarts] #61: The fedora:23 ships service configuration in /etc/systemd/system

[fedora-badges]

#61: The fedora:23 ships service configuration in /etc/systemd/system
-----------------------------+---------------------
  Reporter:  adelton         |      Owner:  kanarip
      Type:  defect          |     Status:  new
  Priority:  major           |  Milestone:
 Component:  kickstart pool  |   Keywords:
Blocked By:                  |   Blocking:
-----------------------------+---------------------
 = bug description =

 The fedora:23 image contains /etc/systemd/system/dbus.service. Since the
 image is a vendor content, it should not contain such modifications that
 are reserved for admin's local changes.

 = bug analysis =

 The man systemd.unit(5) says

 {{{
        Along with a unit file foo.service, a directory foo.service.d/ may
        exist. All files with the suffix ".conf" from this directory will
 be
        parsed after the file itself is parsed. This is useful to alter or
 add
        configuration settings to a unit, without having to modify their
 unit
        files.
 }}}

 and also includes

 {{{
        │/etc/systemd/system     │ Local configuration │
        ├────────────────────────┼─────────────────────┤
        │/run/systemd/system     │ Runtime units       │
        ├────────────────────────┼─────────────────────┤
        │/usr/lib/systemd/system │ Units of installed  │
        │                        │ packages            │
 }}}

 = fix recommendation =

 The file seems to be generated by

 {{{
 +#Make it easier for systemd to run in Docker container
 +cp /usr/lib/systemd/system/dbus.service /etc/systemd/system/
 +sed -i 's/OOMScoreAdjust=-900//' /etc/systemd/system/dbus.service
 }}}

 I recommend putting the OOMScoreAdjust reset to /usr, using something like

 {{{
 ( echo '[Service]' ; echo OOMScoreAdjust=0 ) >
 /usr/lib/systemd/system/dbus.service.d/nooomscoreadjust.conf
 }}}

 Alternatively just removing those lines that create
 /etc/systemd/system/dbus.service altogether might work -- I did not see
 any issues running systemd with dbus on Fedora 23 with fedora:23 image
 with /etc/systemd/system/dbus.service removed.

-- 
Ticket URL: <https://fedorahosted.org/spin-kickstarts/ticket/61>
spin-kickstarts <https://fedorahosted.org/spin-kickstarts/>
Kickstarts that the Spin SIG reviews, tests, maintains and releases (as a package).