Saggi Mizrahi has uploaded a new change for review.
Change subject: Refactor storage connection subsystem
......................................................................
Refactor storage connection subsystem
The current one is an abysmal mess. This is a tramsitional patch
retrofitting the old API to some of the concept we intend to implement.
This introduces ConnectionMonitor. It currently doesn't do any
monitoring just connects and disconnects from storage. It uses URIs for
specifying storage targets which is more generic and simple to parse.
Notice:
Permissions are no longer checked on storage connect only on domain
initialization. This is good as the storage connection is far from an
apropriate place for that check.
I've removed stale root folder handling for NFS. I will add it back I
can't do everything at once.
There are also no proper engine acceptable exceptions yet
Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
---
M vdsm.spec.in
M vdsm/storage/Makefile.am
A vdsm/storage/connectionMonitor.py
M vdsm/storage/fileSD.py
M vdsm/storage/hsm.py
M vdsm/storage/iscsi.py
M vdsm/storage/localFsSD.py
M vdsm/storage/misc.py
M vdsm/storage/mount.py
M vdsm/storage/multipath.py
M vdsm/storage/nfsSD.py
A vdsm/storage/storageMailbox.py
D vdsm/storage/storage_connection.py
A vdsm/storage/sync.py
14 files changed, 884 insertions(+), 486 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/1038/1
--
To view, visit http://gerrit.ovirt.org/1038
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP] Move the VDSM common code to the python site lib
......................................................................
[WIP] Move the VDSM common code to the python site lib
Some VDSM code is shared between different components (eg: vdsm and
vdsm-cli share vdscli.py) and some modules have a really common name
(eg: utils, config) risking to collide with other packages.
For these two reasons and for cleanliness some modules are moved to
a new location (the standard python site lib) and they can be shipped
in a different package.
Change-Id: I4baa573532e41f47bbb19a011856c876f851a2b6
---
M configure.ac
M vds_bootstrap/vds_bootstrap.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/caps.py
M vdsm/clientIF.py
M vdsm/config.py
M vdsm/configNetwork.py
M vdsm/get-conf-item
M vdsm/guestIF.py
M vdsm/hooks.py
M vdsm/kaxmlrpclib.py
M vdsm/ksm.py
M vdsm/libvirtconnection.py
M vdsm/libvirtvm.py
M vdsm/netinfo.py
M vdsm/set-conf-item
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/devicemapper.py
M vdsm/storage/dispatcher.py
M vdsm/storage/fileSD.py
M vdsm/storage/fileUtils.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/iscsi.py
M vdsm/storage/lvm.py
M vdsm/storage/misc.py
M vdsm/storage/multipath.py
M vdsm/storage/outOfProcess.py
M vdsm/storage/processPool.py
M vdsm/storage/resourceFactories.py
M vdsm/storage/safelease.py
M vdsm/storage/sd.py
M vdsm/storage/sdc.py
M vdsm/storage/sp.py
M vdsm/storage/storage_connection.py
M vdsm/storage/storage_mailbox.py
M vdsm/storage/task.py
M vdsm/storage/taskManager.py
M vdsm/storage/volume.py
M vdsm/substitute_constants.py
M vdsm/supervdsm.py
M vdsm/supervdsmServer.py
M vdsm/ut/ivdsm.py
M vdsm/ut/testGuestChannel.py
M vdsm/utils.py
M vdsm/vdsm
M vdsm/vm.py
M vdsm_cli/Makefile.am
M vdsm_cli/dumpStorageTable.py
M vdsm_cli/vdsClient.py
M vdsm_cli/vdscli.py.in
M vdsm_hooks/faqemu/before_vm_start.py
M vdsm_hooks/vhostmd/after_vm_destroy.py
M vdsm_reg/rhevm.py
M vdsm_reg/vdsm-reg-setup
57 files changed, 144 insertions(+), 129 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/286/1
--
To view, visit http://gerrit.ovirt.org/286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4baa573532e41f47bbb19a011856c876f851a2b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Make validateStorageServerConnection API call a noop
......................................................................
Make validateStorageServerConnection API call a noop
This call is useless and slow. It check different things in different
levels for different storage types and does not guarantee a future
connect will succeed. Until someone actually defines what is actually
being validated (params? hostname? permissions? authentication tokens?)
I suggest to just disable this verb so it doesn't make any NFS
connection take twice as long and be exponentially more complex.
Change-Id: Ia56e7bb5b3f725de8f9a8e4498c67ff20b83824b
---
M vdsm/storage/hsm.py
1 file changed, 4 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/1097/1
--
To view, visit http://gerrit.ovirt.org/1097
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia56e7bb5b3f725de8f9a8e4498c67ff20b83824b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Adam Litke has uploaded a new change for review.
Change subject: storagePool: Reject unknown method in uploadVolume
......................................................................
storagePool: Reject unknown method in uploadVolume
Address a previously identified TODO in the code and report an error if a method
other than 'wget' or 'rsync' is specified.
Change-Id: I35267fab74a98bab351e4e66b9349ded69c573ee
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm/storage/sp.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/671/1
--
To view, visit http://gerrit.ovirt.org/671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35267fab74a98bab351e4e66b9349ded69c573ee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>