March 2012 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: Add function getNetworkList to API bridge

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: Add function getNetworkList to API bridge ...................................................................... Patch Set 2: strictly speaking, the BindingRest function may call API.Global.getCapabilities() for this info, without introducing a new API entry. I'm not saying that listNetworks cannot be added to the API, just that BindingXmlrpc and BindingRest should use the same API, when possible. -- To view, visit http://gerrit.ovirt.org/2664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6689b31541fc98ff7a7951eedbb99270c60a0738 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>

12 years, 1 month

1
0
0 / 0

Change in vdsm[master]: Add function getNetworkList to API bridge

by agl＠us.ibm.com

Adam Litke has posted comments on this change. Change subject: Add function getNetworkList to API bridge ...................................................................... Patch Set 2: I would prefer that you didn't submit this (1 inline comment) Dan: Bindings are not allowed to call into vdsm internal functions. They must only call into API.py. Therefore, if we want a listNetworks API to be exposed, we must add the appropriate call to API.py (even if BindingXMLRPC chooses not to expose it). .................................................... File vdsm/API.py Line 1209: print "Networks:", networkList Li Lei, don't forget to remove this debug statement in the next patch series. -- To view, visit http://gerrit.ovirt.org/2664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6689b31541fc98ff7a7951eedbb99270c60a0738 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>

12 years, 1 month

1
0
0 / 0

Change in vdsm[master]: Re-organized internal network APIs in API bridge

by agl＠us.ibm.com

Adam Litke has posted comments on this change. Change subject: Re-organized internal network APIs in API bridge ...................................................................... Patch Set 1: I would prefer that you didn't submit this (5 inline comments) Just some general naming changes in addition to Dan's suggestion. .................................................... File vdsm/API.py Line 930: """Add a new network to this vds. Since this is already in a class called Network, the function can be named simply: 'add'. Line 959: """Delete a network from this vds.""" name this one 'delete' Line 997: nics=None, options={}): Name this one 'edit' Line 1023: """Add a new network to this vds, replacing an old one.""" You can name this one 'setup'. Line 1186 Can you move this one into the Network class too please? -- To view, visit http://gerrit.ovirt.org/2663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64771991c3db09247f7689e6b5ddffa8adbf6745 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in vdsm[master]: build: Add guestIF_test.py to Makefile.am

by agl＠us.ibm.com

Adam Litke has uploaded a new change for review. Change subject: build: Add guestIF_test.py to Makefile.am ...................................................................... build: Add guestIF_test.py to Makefile.am guestIF_test.py is missing from tests/Makefile.am and this is causing make to fail. Add it to Makefile.am to fix the build. Change-Id: I2a9a782e0200d922bab07d8439c786922cfd141e Signed-off-by: Adam Litke <agl(a)us.ibm.com> --- M tests/Makefile.am 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/3176/1 -- To view, visit http://gerrit.ovirt.org/3176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a9a782e0200d922bab07d8439c786922cfd141e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>

12 years, 1 month

2
2
0 / 0

Change in vdsm[master]: vdsm: error when creating a bond with more than one entwork ...

by danny.ran＠redhat.com

Danny Rankevich has uploaded a new change for review. Change subject: vdsm: error when creating a bond with more than one entwork attached ...................................................................... vdsm: error when creating a bond with more than one entwork attached When creating a Bond with more than one network attached, the code breaks since it is expecting a dictionary, but a list is used. This fix creates the dictionary in the correct way. Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854 --- M vdsm/configNetwork.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/3010/1 -- To view, visit http://gerrit.ovirt.org/3010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ice52835a3a73d48233bd1022f6a8d9d0f381e854 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Danny Rankevich <danny.ran(a)redhat.com>

12 years, 1 month

4
10
0 / 0

Change in vdsm[master]: Fix bad import preventing SuperVdsm to start

by Haim Ateya

Haim Ateya has uploaded a new change for review. Change subject: Fix bad import preventing SuperVdsm to start ...................................................................... Fix bad import preventing SuperVdsm to start Change-Id: If54ea19624d7400258e9b73c33ebb11f1f2e5941 --- M vdsm/tc.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/3194/1 -- To view, visit http://gerrit.ovirt.org/3194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If54ea19624d7400258e9b73c33ebb11f1f2e5941 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Haim Ateya <hateya(a)redhat.com>

12 years, 1 month

3
4
0 / 0

Change in vdsm[master]: Add partial live merge

by Federico Simoncelli

Federico Simoncelli has uploaded a new change for review. Change subject: Add partial live merge ...................................................................... Add partial live merge Let's activate the partial live merge (libvirt supports it). Change-Id: I010838646a742c83efa910a192ddaeba89cf8159 --- M vdsm/libvirtvm.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/3188/1 -- To view, visit http://gerrit.ovirt.org/3188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I010838646a742c83efa910a192ddaeba89cf8159 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

12 years, 1 month

3
3
0 / 0

Change in vdsm[master]: Use the REUSE_EXT flag in snapshotCreateXML

by Federico Simoncelli

Federico Simoncelli has uploaded a new change for review. Change subject: Use the REUSE_EXT flag in snapshotCreateXML ...................................................................... Use the REUSE_EXT flag in snapshotCreateXML Change-Id: Icfa2a0aa80867ec3ee34e6e2dfd31d6a16a1f135 --- M vdsm/libvirtvm.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/3115/1 -- To view, visit http://gerrit.ovirt.org/3115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icfa2a0aa80867ec3ee34e6e2dfd31d6a16a1f135 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

12 years, 1 month

3
5
0 / 0

Change in vdsm[master]: Make misc.py conform pep8 and other minor cleanup

by smizrahi＠redhat.com

Saggi Mizrahi has uploaded a new change for review. Change subject: Make misc.py conform pep8 and other minor cleanup ...................................................................... Make misc.py conform pep8 and other minor cleanup Change-Id: Ifd94b8b8223a99765c519f5a321043986795b7c7 --- M vdsm/storage/misc.py 1 file changed, 216 insertions(+), 115 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/3047/1 -- To view, visit http://gerrit.ovirt.org/3047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd94b8b8223a99765c519f5a321043986795b7c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

12 years, 1 month

2
5
0 / 0

Change in vdsm[master]: Revert "added a very very simple test for the function filte...

by Igor Lvovsky

Igor Lvovsky has submitted this change and it was merged. Change subject: Revert "added a very very simple test for the function filterXmlChars in the guestIF module" ...................................................................... Revert "added a very very simple test for the function filterXmlChars in the guestIF module" This reverts commit 14e80f5e65cd2d11a00987ba3f8b8e1bc5021107 as it fails common `make`. --- M tests/Makefile.am D tests/guestIF_test.py 2 files changed, 1 insertion(+), 37 deletions(-) Approvals: Igor Lvovsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1866a3a1aaefdc5a0537b83b193ac1065d938e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>

12 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches March 2012