vdsm-patches June 2017

vdsm-patches@lists.fedorahosted.org

1 participants
244 discussions

Change in vdsm[master]: static: fix passwd file path
by Code Review 27 Jun '17

27 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: static: fix passwd file path ...................................................................... static: fix passwd file path Use full local path to make sure `make` finds the file. Without this patch, I hit make[2]: Entering directory '/home/fromani/Projects/upstream/vdsm/static' make[2]: *** No rule to make target 'usr/local/etc/pki/vdsm/keys/libvirt_password', needed by 'distdir'. Stop. make[2]: Leaving directory '/home/fromani/Projects/upstream/vdsm/static' Makefile:625: recipe for target 'distdir' failed While doing 'make rpm'. Change-Id: Id2ff0699fc7ecebf430d1655ffdf9553932beaf2 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M static/Makefile.am 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Milan Zamazal: Looks good to me, but someone else must approve Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2ff0699fc7ecebf430d1655ffdf9553932beaf2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: static: fix passwd file path
by Code Review 27 Jun '17

27 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: static: fix passwd file path ...................................................................... Patch Set 2: Code-Review+2 oh dear, I don't quite understand how I did not see this. sorry for the breakage. -- To view, visit https://gerrit.ovirt.org/78671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2ff0699fc7ecebf430d1655ffdf9553932beaf2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: python3: Fix UUID packing/unpacking on python 3
by Code Review 27 Jun '17

27 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: python3: Fix UUID packing/unpacking on python 3 ...................................................................... Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/78632/9/tests/storage/misc_test.py File tests/storage/misc_test.py: Line 459: return b.encode("hex") Line 460: Line 461: Line 462: # Note: packed values were generated by misc.packUuid(), to ensure that we keep Line 463: # the packed format. > Suggest a better way to test it? a constant list of reproducible uuids (could be a seeded pseudo-random) Line 464: @pytest.mark.parametrize("bytes,packed", [ Line 465: # The smallest possible random value Line 466: (b"\x00" * 16, Line 467: b"\x00\x00\x00\x00\x00\x00\x00\x80\x00@\x00\x00\x00\x00\x00\x00"), -- To view, visit https://gerrit.ovirt.org/78632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41cfa5e54e76dfcad267792daebc54e80bf2a022 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: cleanup: remove unused mk_sysprep_floppy
by Code Review 27 Jun '17

27 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: cleanup: remove unused mk_sysprep_floppy ...................................................................... cleanup: remove unused mk_sysprep_floppy Change I27f176378 dropped the code calling this helper script. There is no need to keep it behind. Change-Id: I3016d7bdcbefedd3501abbe92b29637db59c13b5 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M .gitignore M lib/vdsm/constants.py.in M static/etc/sudoers.d/50_vdsm.in R static/libexec/vdsm/mk_sysprep_floppy.in M vdsm.spec.in M vdsm/Makefile.am 6 files changed, 1 insertion(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/78584/1 diff --git a/.gitignore b/.gitignore index 88b34f4..7251e4f 100644 --- a/.gitignore +++ b/.gitignore @@ -71,7 +71,6 @@ tests/other.key vdsm-*.tar.gz vdsm.spec -vdsm/mk_sysprep_floppy vdsm/sos/vdsm.py vdsm/vdscli.py vdsm/vdsm-gencerts.sh diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in index 950c70d..18d71b2 100644 --- a/lib/vdsm/constants.py.in +++ b/lib/vdsm/constants.py.in @@ -125,7 +125,6 @@ EXT_MKFS = '@MKFS_PATH@' EXT_MKFS_MSDOS = '@MKFS_MSDOS_PATH@' EXT_MKISOFS = '@MKISOFS_PATH@' -EXT_MK_SYSPREP_FLOPPY = '@VDSMDIR@/mk_sysprep_floppy' # NOQA: E501 (potentially long line) EXT_MOUNT = '@MOUNT_PATH@' EXT_MULTIPATH = '@MULTIPATH_PATH@' diff --git a/static/etc/sudoers.d/50_vdsm.in b/static/etc/sudoers.d/50_vdsm.in index c88ac8d..26e4da1 100644 --- a/static/etc/sudoers.d/50_vdsm.in +++ b/static/etc/sudoers.d/50_vdsm.in @@ -1,6 +1,5 @@ Cmnd_Alias VDSM_LIFECYCLE = \ - @DMIDECODE_PATH@ -s system-uuid, \ - @VDSMDIR@/mk_sysprep_floppy + @DMIDECODE_PATH@ -s system-uuid Cmnd_Alias VDSM_STORAGE = \ @FSCK_PATH@ -p *, \ @TUNE2FS_PATH@ -j *, \ diff --git a/vdsm/mk_sysprep_floppy.in b/static/libexec/vdsm/mk_sysprep_floppy.in similarity index 100% rename from vdsm/mk_sysprep_floppy.in rename to static/libexec/vdsm/mk_sysprep_floppy.in diff --git a/vdsm.spec.in b/vdsm.spec.in index 168bf2b..1a0c08a 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -891,7 +891,6 @@ %{_datadir}/%{vdsm_name}/daemonAdapter %{_datadir}/%{vdsm_name}/API.py* %{_datadir}/%{vdsm_name}/hooking.py* -%{_datadir}/%{vdsm_name}/mk_sysprep_floppy %{_datadir}/%{vdsm_name}/sitecustomize.py* %{_datadir}/%{vdsm_name}/supervdsmd %{_datadir}/%{vdsm_name}/vdsmd diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am index 3df78ed..abeaf62 100644 --- a/vdsm/Makefile.am +++ b/vdsm/Makefile.am @@ -34,9 +34,6 @@ vdsm-gencerts.sh \ $(NULL) -nodist_vdsm_SCRIPTS = \ - mk_sysprep_floppy - dist_vdsm_SCRIPTS = \ get-conf-item \ set-conf-item \ @@ -54,7 +51,6 @@ EXTRA_DIST = \ dhclientmon.sh \ libvirt_password \ - mk_sysprep_floppy.in \ vdsm-gencerts.sh.in \ vdsm-libvirt-access.pkla \ vdsm-libvirt-access.rules \ -- To view, visit https://gerrit.ovirt.org/78584 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3016d7bdcbefedd3501abbe92b29637db59c13b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 5

Change in vdsm[master]: drop vdsm/vdsm-libvirt-access.pkla
by Code Review 27 Jun '17

27 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: drop vdsm/vdsm-libvirt-access.pkla ...................................................................... drop vdsm/vdsm-libvirt-access.pkla It should have been removed with its single user, the debian packaging attempt. Change-Id: I486bb9c9f9f38b38c5822ebb18fc80c7a4224aa3 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/Makefile.am D vdsm/vdsm-libvirt-access.pkla 2 files changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/78552/1 diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am index b36f56e..4a297b2 100644 --- a/vdsm/Makefile.am +++ b/vdsm/Makefile.am @@ -52,7 +52,6 @@ EXTRA_DIST = \ mk_sysprep_floppy.in \ vdsm-gencerts.sh.in \ - vdsm-libvirt-access.pkla \ $(NULL) all-local: \ diff --git a/vdsm/vdsm-libvirt-access.pkla b/vdsm/vdsm-libvirt-access.pkla deleted file mode 100644 index cdeff62..0000000 --- a/vdsm/vdsm-libvirt-access.pkla +++ /dev/null @@ -1,6 +0,0 @@ -[VDSM libvirt access] -Identity=unix-user:vdsm -Action=org.libvirt.unix.manage -ResultAny=yes -ResultInactive=yes -ResultActive=yes -- To view, visit https://gerrit.ovirt.org/78552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I486bb9c9f9f38b38c5822ebb18fc80c7a4224aa3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 2

Change in vdsm[master]: hugepages: add support for shared pages
by Code Review 27 Jun '17

27 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: hugepages: add support for shared pages ...................................................................... Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/77808/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 426: Line 427: @property Line 428: def hugepages_shared(self): Line 429: custom = self._custom['custom'] Line 430: hugepages_shared = conv.tobool(custom.get('hugepages_shared', False)) a variable named just like its scope is very confusing. can you choose another name? this, too, would be solved if the property is declared private as suggested by Francesco. Line 431: return hugepages_shared Line 432: Line 433: def _get_lastStatus(self): Line 434: # note that we don't use _statusLock here. One of the reasons is the -- To view, visit https://gerrit.ovirt.org/77808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eb7b20a16e3e4a0d57da02ff7490136071dd8f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: net: Unified configuration existance can have only nets or b...
by Code Review 27 Jun '17

27 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Unified configuration existance can have only nets or bonds ...................................................................... net: Unified configuration existance can have only nets or bonds Both are not required. Change-Id: Ia3b0c9e00241c9b4e3a11e56a0a93cc6d1246996 Bug-Url: https://bugzilla.redhat.com/1457889 Signed-off-by: Edward Haas <edwardh(a)redhat.com> --- M lib/vdsm/network/netconfpersistence.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Burman: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78663 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3b0c9e00241c9b4e3a11e56a0a93cc6d1246996 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: Generate dump bonding options on boot and upgrade
by Code Review 27 Jun '17

27 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Generate dump bonding options on boot and upgrade ...................................................................... Patch Set 30: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/78006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: tests: Make mailbox_test compatible with pytest
by Code Review 27 Jun '17

27 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: tests: Make mailbox_test compatible with pytest ...................................................................... Patch Set 6: Code-Review-1 (1 comment) -1 for visibility only https://gerrit.ovirt.org/#/c/78589/6/tests/storage/mailbox_test.py File tests/storage/mailbox_test.py: PS6, Line 100: I don't remember what this test is really for, but the mailer.run() call smells crucial here. Are you sure you are not simplifying the test too much? -- To view, visit https://gerrit.ovirt.org/78589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67aaf03e382c730757e8d3d208267d177ea325c6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: python3: Fix UUID packing/unpacking on python 3
by Code Review 27 Jun '17

27 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: python3: Fix UUID packing/unpacking on python 3 ...................................................................... Patch Set 9: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/78632/9/tests/storage/misc_test.py File tests/storage/misc_test.py: Line 453: Line 454: Line 455: class TestUuidPack(VdsmTestCase): Line 456: Line 457: def test(self): this test is not good enough for this refactoring: you'd probably want to prove that you do not change existing packing. please consider adding such a test before merging. Line 458: """ Line 459: Test that the uuid that was packed can be unpacked without being Line 460: changed Line 461: """ PS9, Line 463: uuid.uuid4() unrelated to this patch: randomness in tests is a liability. if this test fails once in a million, we would not notice. -- To view, visit https://gerrit.ovirt.org/78632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41cfa5e54e76dfcad267792daebc54e80bf2a022 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

← Newer
1
2
3
4
5
6
7
...
25
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches June 2017