Change in vdsm[master]: sos: fix addCopySpecLimit call
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79510 )
Change subject: sos: fix addCopySpecLimit call
......................................................................
sos: fix addCopySpecLimit call
sosreport 3.4 replace add_copy_spec_limit with
add_copy_spec.
commit 2e2559d4f3dd7625e52aad3314379ef1ee2afe41 replaced
this call but apperantly in prior sosreport versions,
number of parameters of add_copy_spec method was different and
caused a TypeError.
Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1471663
---
M lib/sos/vdsm.py.in
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: sos: fix addCopySpecLimit call
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: sos: fix addCopySpecLimit call
......................................................................
Patch Set 4: Code-Review+1 Verified+1
added REQUIRED_FOR in the comment - danken requested. didn't change code
--
To view, visit https://gerrit.ovirt.org/79510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: sos: fix addCopySpecLimit call
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: sos: fix addCopySpecLimit call
......................................................................
Patch Set 2:
verified with sos-3.4-1 and 3.3-5
--
To view, visit https://gerrit.ovirt.org/79510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: sos: fix addCopySpecLimit call
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: sos: fix addCopySpecLimit call
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/79510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: sos: fix addCopySpecLimit call
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: sos: fix addCopySpecLimit call
......................................................................
Patch Set 2: Code-Review+1
great. thanks!
--
To view, visit https://gerrit.ovirt.org/79510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: spec: install libvirt-hook.sh in Makefile.am
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: spec: install libvirt-hook.sh in Makefile.am
......................................................................
spec: install libvirt-hook.sh in Makefile.am
Another step to clean %install in the spec file.
Change-Id: Ib9affdae684a6a2b33a98d82759c2c05fcca880e
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/virt/Makefile.am
M vdsm.spec.in
2 files changed, 2 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/79435/1
diff --git a/lib/vdsm/virt/Makefile.am b/lib/vdsm/virt/Makefile.am
index 7bcad61..84c97fd 100644
--- a/lib/vdsm/virt/Makefile.am
+++ b/lib/vdsm/virt/Makefile.am
@@ -55,6 +55,7 @@
vm_migrate_hook.py \
$(NULL)
-EXTRA_DIST = \
+libvirthoookdir = /etc/libvirt/hooks/qemu
+dist_libvirthoook_SCRIPTS = \
libvirt-hook.sh \
$(NULL)
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 8ba16d8..9e28859 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -743,10 +743,6 @@
install -dDm 1777 %{buildroot}%{_localstatedir}/log/core
%endif
-# Install the libvirt hook for cleaning up the XML
-install -Dm 0755 lib/vdsm/virt/libvirt-hook.sh \
- %{buildroot}%{_sysconfdir}/libvirt/hooks/qemu
-
%pre
# Force standard locale behavior (English)
export LC_ALL=C
--
To view, visit https://gerrit.ovirt.org/79435
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9affdae684a6a2b33a98d82759c2c05fcca880e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: stomp: fix AsyncDispatcher next_check_interval
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: fix AsyncDispatcher next_check_interval
......................................................................
Patch Set 4: Code-Review+1
Irit's comment is correct - The discussion we have is not related to this fix. The code here is just wrong and must have this patch also in 4.1 - without any relation to the following patches
--
To view, visit https://gerrit.ovirt.org/79384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: stomp: fix AsyncDispatcher next_check_interval
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: fix AsyncDispatcher next_check_interval
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/79384/4/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 413: self._incoming_heartbeat_in_milis == 0:
Line 414: return None
Line 415:
Line 416: if self._incoming_heartbeat_in_milis and \
Line 417: self._incoming_heartbeat_expiration_interval() < 0:
> We need timeouts, and instead of having a proper solution, we hacked this n
from what I understand the complexity is redundant in this code. we have a mess of implementations that part of them Im quite sure we don't use any more.
My problem is that I just can't map the dependencies between objects here each time I try to go over this code :| maybe its only be. but its exhausting
I'm not sure how urgent is the heartbeat feature - if it is for 4.1, lets hack this craziness again. but we can't keep doing that..
Do we still need the protocol detector? How many kind of "Dispatchers" we need? can we have only one Dispatcher implantation?
It still kills me why StompAdapterImpl and AsyncClient are not called frame handlers? why those can't be kind of dispatchers? all this hierarchy must be reconsidered and fixed.
Its long run changes that we can do in those areas.. I think we can rethink and make it much nicer... depends on priorities and desire
Line 418: self.handle_timeout()
Line 419: return None
Line 420:
Line 421: if self._outgoing_heartbeat_in_milis:
--
To view, visit https://gerrit.ovirt.org/79384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: gitignore: remove needless line
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: gitignore: remove needless line
......................................................................
gitignore: remove needless line
commit 930686 removed this script, but forgot to clean .gitignore of it.
Change-Id: I7188a1b5ec7dc2bcb56844e3c2963708dd81cfd3
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M .gitignore
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/79427/1
diff --git a/.gitignore b/.gitignore
index 9937872..e334131 100644
--- a/.gitignore
+++ b/.gitignore
@@ -77,5 +77,4 @@
static/usr/share/man/man8/vdsmd.8
vdsm/rpc/vdsm-api.html
vdsm_hooks/openstacknet/sudoers
-vdsm_hooks/persist-vdsm-hooks
vdsm_hooks/checkips/vdsm-checkips.service
--
To view, visit https://gerrit.ovirt.org/79427
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7188a1b5ec7dc2bcb56844e3c2963708dd81cfd3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: RPC: JsonRpcClient supports multiple subscriptions
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: JsonRpcClient supports multiple subscriptions
......................................................................
Patch Set 31:
(1 comment)
https://gerrit.ovirt.org/#/c/78656/31/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 595: Set a callback which handles messages received
Line 596: from the main RPC queue.
Line 597:
Line 598: :param handler: Callback to handle incoming messages
Line 599: :type handler: function (string) -> ()
> The notation should mean, that the type of the 'handler' parameter is: 'fun
im confused what is this handler again. you should pass here JsonRpcClient instance or just the handle_message function pointer? err so not clear. for some reason I though this function gets class that implements the handle_message function
Line 600: """
Line 601: self._message_handler = handler
Line 602:
Line 603: def send(self, data, destination=None):
--
To view, visit https://gerrit.ovirt.org/78656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months