Change in vdsm[master]: net: remove vintage ovirt-node code piece
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: net: remove vintage ovirt-node code piece
......................................................................
net: remove vintage ovirt-node code piece
ovirt-node vintage is not with us since ovirt 3. This patch removes a
piece of dead code.
Change-Id: I73820d7adc73810936571e5698e0347ebb977d95
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/79293/1
diff --git a/lib/vdsm/network/configurators/ifcfg.py b/lib/vdsm/network/configurators/ifcfg.py
index 92dbcf5..d4fcf70 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -460,10 +460,6 @@
@classmethod
def _persistentBackup(cls, filename):
""" Persistently backup ifcfg-* config files """
- if os.path.exists('/usr/libexec/ovirt-functions'):
- cmd.exec_sync([constants.EXT_SH, '/usr/libexec/ovirt-functions',
- 'unmount_config', filename])
- logging.debug("unmounted %s using ovirt", filename)
(dummy, basename) = os.path.split(filename)
try:
--
To view, visit https://gerrit.ovirt.org/79293
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73820d7adc73810936571e5698e0347ebb977d95
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: net: NM acquire should ignore duplicate ifcfg files
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/79349/1/lib/vdsm/network/nm/nmdbus/__init__.py
File lib/vdsm/network/nm/nmdbus/__init__.py:
Line 67: """
Line 68: con_info = (None, None)
Line 69: try:
Line 70: con_info = self.ifcfg.GetIfcfgDetails(ifcfg_path)
Line 71: except DBusException as ex:
yuck, don't they have numeric exception names?
Line 72: for err_base_message in NMDbusIfcfgRH1.ERROR_INV_CON:
Line 73: if err_base_message.format(ifcfg_path) == ex.args[0]:
Line 74: return con_info
Line 75: raise
--
To view, visit https://gerrit.ovirt.org/79349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: virt: remove vdsm/virt directory
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: remove vdsm/virt directory
......................................................................
Patch Set 2: Code-Review+2
!
--
To view, visit https://gerrit.ovirt.org/79339
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31bd6bbd28021ddf16036c129a2bb4283c7e369d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: net: Report lldp through new getLldp command
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report lldp through new getLldp command
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/79093/5/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 284: def remove_ovs_port(bridge, port):
Line 285: netswitch.configurator.ovs_remove_port(bridge, port)
Line 286:
Line 287:
Line 288: def lldp_info(device):
> getVMList has a "vmList" argument specifying which vmid are interesting to
I do not see an easy way (or immediate need) to specify TLVs that are interesting to the client. Let us not block on this question and return them all; if a limiting filter becomes useful, we can add an additional argument.
Line 289: """"
Line 290: Get LLDP information of a device.
Line 291:
Line 292: Returns LLDP Information
--
To view, visit https://gerrit.ovirt.org/79093
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: RPC: JsonRpcClient supports multiple subscriptions
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: JsonRpcClient supports multiple subscriptions
......................................................................
Patch Set 28: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/78656/28//COMMIT_MSG
Commit Message:
Line 10: responses and only from a single queue.
Line 11:
Line 12: Now it is possible to subscribe to multiple queues
Line 13: and receive also events as well as rpc responses.
Line 14:
how?
you need to explain here the logic you add - how the callback is being used, when we need callback when we handle_msg and how its being set
Line 15: Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
https://gerrit.ovirt.org/#/c/78656/28/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 497:
Line 498: def _handleMessage(self, message, callback=None):
Line 499: try:
Line 500: mobj = json.loads(message)
Line 501: isResponse = self._isResponse(mobj)
yes? events are not count as response? kill me, but I don't get the _isResponse implementation, so you'll tell me if its indeed work as expected
Line 502: except:
Line 503: self.log.exception("Problem parsing message from client")
Line 504: return
Line 505:
Line 522:
Line 523: req = JsonRpcRequest.fromRawObject(obj)
Line 524: if not req.isNotification():
Line 525: self.log.warning("Received non notification, ignoring")
Line 526: return
separate patch please
Line 527:
Line 528: callback(req.method, req.params)
Line 529:
Line 530: def close(self):
https://gerrit.ovirt.org/#/c/78656/28/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 606: destination,
Line 607: headers,
Line 608: )
Line 609:
Line 610: def subscribe(self, queue_name, handler):
what is handler?
Line 611: sub_id = uuid4()
Line 612: self._subs[sub_id] = self._client.subscribe(
Line 613: queue_name,
Line 614: sub_id=str(sub_id),
--
To view, visit https://gerrit.ovirt.org/78656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: RPC: Small refactor of ClientRpcTransportAdapter
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Small refactor of ClientRpcTransportAdapter
......................................................................
Patch Set 22: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/78655/22/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 573: class ClientRpcTransportAdapter(object):
Line 574: def __init__(self, request_queue, response_queue, client):
Line 575: self._client = client
Line 576: self._message_handler = lambda arg: None
Line 577: self._request_queue = request_queue
how this request queue is being used?
when you send data without destination, you add it to this queue and how is it being handled?
Line 578:
Line 579: self._sub = self._client.subscribe(
Line 580: response_queue,
Line 581: sub_id=str(uuid4()),
Line 587: handler which is responsible for processing jsonrpc
Line 588: content of the message. Currently, the only handler
Line 589: is JsonRpcClient.
Line 590: """
Line 591: def set_message_handler(self, handler):
so call it - set_jsonrpc_client
Line 592: self._message_handler = handler
Line 593:
Line 594: def send(self, data, destination=None):
Line 595: if not destination:
Line 588: content of the message. Currently, the only handler
Line 589: is JsonRpcClient.
Line 590: """
Line 591: def set_message_handler(self, handler):
Line 592: self._message_handler = handler
also the var - self._jsonrpcclient
what is message handler?
Line 593:
Line 594: def send(self, data, destination=None):
Line 595: if not destination:
Line 596: destination = self._request_queue
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: RPC: Add missing return statement when handling messages
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Add missing return statement when handling messages
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/79308/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 482: transport, message = req
Line 483: try:
Line 484: mobj = json.loads(message)
Line 485: isResponse = self._isResponse(mobj)
Line 486: except:
if you're already here - add specific catch if possible to be more explicit
Line 487: self.log.exception("Problem parsing message from client")
Line 488: return
Line 489:
Line 490: if isResponse:
--
To view, visit https://gerrit.ovirt.org/79308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04ce4a5c6758e7bf0272ffac51f0cec89e3f6b8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC client: Add methods to subscribe, unsubscribe and notify
......................................................................
Patch Set 21:
I like the tests, but it sounds odd that we don't have client_test module already ... so I grabbed for it and saw some tests in stompTests - worth to put all client tests under your new test module
Thanks!
--
To view, visit https://gerrit.ovirt.org/78657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5b1e2eace452bf663c34c721bbe3ff9fcabb095
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC client: Add methods to subscribe, unsubscribe and notify
......................................................................
Patch Set 21: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/78657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5b1e2eace452bf663c34c721bbe3ff9fcabb095
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: RPC: Recieve and parse messages from multiple subscriptions
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Recieve and parse messages from multiple subscriptions
......................................................................
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/78656/23//COMMIT_MSG
Commit Message:
Line 7: RPC: Recieve and parse messages from multiple subscriptions
Line 8:
Line 9: JsonRpcClient parses json messages
Line 10: from multiple subscriptions and calls
Line 11: the registered callback.
> Ok, I will rephrase it.
yes, explain how, and how it was - code-wise
Line 12:
Line 13: Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
--
To view, visit https://gerrit.ovirt.org/78656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months