Change in vdsm[master]: RPC: Add missing return statement when handling messages
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Add missing return statement when handling messages
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/79308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04ce4a5c6758e7bf0272ffac51f0cec89e3f6b8e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: RPC: Small refactor of ClientRpcTransportAdapter
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Small refactor of ClientRpcTransportAdapter
......................................................................
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/78655/24/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 592: """
Line 593: Set a callback which handles received messages
Line 594:
Line 595: :param handler: Callback to handle incoming messages
Line 596: :type handler: function (ClientRpcTransportAdapter, string) -> ()
i don't understand this syntax.
the handle gets ClientRpcTransportAdapter and a string and return nothing? do we have some kind of message handler interface ?
Line 597: """
Line 598: self._message_handler = handler
Line 599:
Line 600: def send(self, data, destination=None):
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: RPC: Add missing return statement
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Add missing return statement
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/79328
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17a948211ba3aa05af2be69c2a2d366aa26a9e9b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: lib: move API
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77571 )
Change subject: lib: move API
......................................................................
lib: move API
As part of bigger effort we move modules from vdsm to lib.vdsm. This
patch moves API.
Change-Id: I8eeff74f4269d886d557a912070b54c1d9d642ff
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M Makefile.am
R lib/vdsm/API.py
M lib/vdsm/Makefile.am
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/errors.py
M lib/vdsm/rpc/Bridge.py
M lib/vdsm/rpc/http.py
M lib/vdsm/storage/volume.py
M lib/vdsm/virt/vm.py
M tests/API_test.py
M tests/bridge_test.py
M tests/check_imports.py
M tests/integration/jsonRpcHelper.py
M tests/schemavalidation_test.py
M tests/vmapi_test.py
M vdsm.spec.in
M vdsm/Makefile.am
17 files changed, 17 insertions(+), 22 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8eeff74f4269d886d557a912070b54c1d9d642ff
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: move vdsmd from vdsm dir
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/69447 )
Change subject: move vdsmd from vdsm dir
......................................................................
move vdsmd from vdsm dir
vdsmd.py moved to lib/vdsm and vdsmd script moved
to static directory
Change-Id: Ib683341bbf3e4ebdcb45c158391c21881b030633
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M Makefile.am
M lib/vdsm/Makefile.am
R lib/vdsm/vdsmd.py
M static/Makefile.am
R static/usr/sbin/vdsmd
M vdsm.spec.in
M vdsm/Makefile.am
7 files changed, 5 insertions(+), 9 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/69447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib683341bbf3e4ebdcb45c158391c21881b030633
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: lib: move clientIF
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77570 )
Change subject: lib: move clientIF
......................................................................
lib: move clientIF
As part of bigger effort we move modules from vdsm to lib.vdsm. This
patch moves clientIF.
Change-Id: If00e1a8e2f4f776315fd04444a06fe3532a2d64e
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M Makefile.am
M lib/vdsm/Makefile.am
R lib/vdsm/clientIF.py
M lib/vdsm/virt/vm.py
M tests/clientif_test.py
M tests/vmapi_test.py
M vdsm.spec.in
M vdsm/API.py
M vdsm/Makefile.am
M vdsm/vdsmd.py
10 files changed, 10 insertions(+), 9 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If00e1a8e2f4f776315fd04444a06fe3532a2d64e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: lib: move API
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: lib: move API
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eeff74f4269d886d557a912070b54c1d9d642ff
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: lib: move clientIF
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: lib: move clientIF
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If00e1a8e2f4f776315fd04444a06fe3532a2d64e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: API: drop needless code
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: API: drop needless code
......................................................................
API: drop needless code
The code dropped in this patch was required for ancient Engine versions
(pre 3.1), which are not supported for a very long time. Read more in
commit 95302a1 which introduced these calls.
Change-Id: I23c13501d20caff1c21cdd422a250ceee7cd7e24
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/rpc/Bridge.py
M vdsm/API.py
2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/79298/1
diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 7d3c6f6..c93423e 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -264,7 +264,6 @@
This call is only interested in returning the VM UUIDs so pass False for
the first argument in order to suppress verbose results.
"""
- API.updateTimestamp() # required for setupNetworks flow
vmList = args.get('vmList', [])
onlyUUID = args.get('onlyUUID', True)
return API.Global().getVMList(False, vmList, onlyUUID)
diff --git a/vdsm/API.py b/vdsm/API.py
index cf7c04e..fc928a7 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1245,7 +1245,6 @@
Report host capabilities.
"""
hooks.before_get_caps()
- updateTimestamp() # required for some ovirt-3.0.z Engines
c = caps.get()
c['netConfigDirty'] = str(self._cif._netConfigDirty)
c = hooks.after_get_caps(c)
--
To view, visit https://gerrit.ovirt.org/79298
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23c13501d20caff1c21cdd422a250ceee7cd7e24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: virt.sampling: drop dead code
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: virt.sampling: drop dead code
......................................................................
virt.sampling: drop dead code
recentClient was used by the connectivity log, and should have been
dropped in commit f68cc2d7. This patch stops updating a field that no
one reads
Change-Id: Ibf858255ff91ac4fe96aecfb66f446f00e84d58f
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/virt/sampling.py
1 file changed, 1 insertion(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/79296/1
diff --git a/lib/vdsm/virt/sampling.py b/lib/vdsm/virt/sampling.py
index 189df9f..53eabb7 100644
--- a/lib/vdsm/virt/sampling.py
+++ b/lib/vdsm/virt/sampling.py
@@ -37,7 +37,7 @@
from vdsm import utils
import vdsm.common.time
from vdsm.config import config
-from vdsm.constants import P_VDSM_RUN, P_VDSM_CLIENT_LOG
+from vdsm.constants import P_VDSM_RUN
from vdsm.host import api as hostapi
from vdsm.network import ipwrapper
from vdsm.network.netinfo import nics, bonding, vlans
@@ -253,15 +253,6 @@
self.cpuCores = CpuCoreSample()
self.numaNodeMem = NumaNodeMemorySample()
ENGINE_DEFAULT_POLL_INTERVAL = 15
- try:
- self.recentClient = (
- self.timestamp - os.stat(P_VDSM_CLIENT_LOG).st_mtime <
- 2 * ENGINE_DEFAULT_POLL_INTERVAL)
- except OSError as e:
- if e.errno == errno.ENOENT:
- self.recentClient = False
- else:
- raise
_MINIMUM_SAMPLES = 1
--
To view, visit https://gerrit.ovirt.org/79296
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf858255ff91ac4fe96aecfb66f446f00e84d58f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months