Change in vdsm[master]: api: log only external pings
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: api: log only external pings
......................................................................
Patch Set 6:
omg, we had quite the same thing in the past: http://gerrit.ovirt.org/30178
--
To view, visit https://gerrit.ovirt.org/78142
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eff40244f38d5707f9e1cec64d20bcd68415b2d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: net: keep our own BRCTL constant
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: net: keep our own BRCTL constant
......................................................................
net: keep our own BRCTL constant
BRCTL has two usages: in vdsm-tool, and in the ifcfg network
configurator. It resolves to /usr/sbin/brctl on all platforms.
In order to facilitate future separation of the network subpackage, this
patch defines network's own copy of BRCTL.
Change-Id: Id49fc16232787c905ce9bda5731c08b2f568849f
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
M tests/functional/networkTests.py
M tests/network/nettestlib.py
3 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/79277/1
diff --git a/lib/vdsm/network/configurators/ifcfg.py b/lib/vdsm/network/configurators/ifcfg.py
index dd35b26..92dbcf5 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -68,6 +68,7 @@
CONFFILE_HEADER_SIGNATURE = '# Generated by VDSM version'
+EXT_BRCTL = '/usr/sbin/brctl'
EXT_IFDOWN = '/sbin/ifdown'
EXT_IFUP = '/sbin/ifup'
@@ -209,7 +210,7 @@
ifacetracking.add(bridge.name)
ifdown(bridge.name)
self._removeSourceRoute(bridge)
- cmd.exec_sync([constants.EXT_BRCTL, 'delbr', bridge.name])
+ cmd.exec_sync([EXT_BRCTL, 'delbr', bridge.name])
self.configApplier.removeBridge(bridge.name)
self.net_info.del_bridge(bridge.name)
if bridge.port:
@@ -774,7 +775,7 @@
ifdown(dev)
if os.path.exists('/sys/class/net/%s/bridge' % dev):
# ifdown is not enough to remove nicless bridges
- cmd.exec_sync([constants.EXT_BRCTL, 'delbr', dev])
+ cmd.exec_sync([EXT_BRCTL, 'delbr', dev])
if _is_bond_name(dev):
if _is_running_bond(dev):
with open(BONDING_MASTERS, 'w') as f:
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 7ec22ef..a47e4cd 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -29,8 +29,7 @@
import six
import vdsm.config
-from vdsm.constants import EXT_BRCTL
-from vdsm.network.configurators.ifcfg import EXT_IFDOWN, EXT_IFUP
+from vdsm.network.configurators.ifcfg import EXT_BRCTL, EXT_IFDOWN, EXT_IFUP
from vdsm.network import ipwrapper
from vdsm.network import netswitch
from vdsm.network.ip import dhclient
diff --git a/tests/network/nettestlib.py b/tests/network/nettestlib.py
index 4122ad4..b3d2927 100644
--- a/tests/network/nettestlib.py
+++ b/tests/network/nettestlib.py
@@ -32,9 +32,10 @@
from nose.plugins.skip import SkipTest
-from vdsm.constants import EXT_BRCTL, EXT_TC
+from vdsm.constants import EXT_TC
from vdsm import cpuarch
from vdsm.network import cmd as cmd
+from vdsm.network.configurators.ifcfg import EXT_BRCTL
from vdsm.network.ip import address
from vdsm.network.ip import dhclient
from vdsm.network.ipwrapper import (
--
To view, visit https://gerrit.ovirt.org/79277
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id49fc16232787c905ce9bda5731c08b2f568849f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: openstacknet hook: do not use vdsm-internal constants
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: openstacknet hook: do not use vdsm-internal constants
......................................................................
openstacknet hook: do not use vdsm-internal constants
Hooks should avoid vdsm internals. Luckily, EXT_BRCTL is already
defined in openstrack_utils. The hook script should use its
locally-available definition.
Change-Id: Iee6647bce1eba3042f00ec74742d0cadc8ab329a
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm_hooks/openstacknet/after_device_create.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/79254/1
diff --git a/vdsm_hooks/openstacknet/after_device_create.py b/vdsm_hooks/openstacknet/after_device_create.py
index f98c166..9e5c8c1 100755
--- a/vdsm_hooks/openstacknet/after_device_create.py
+++ b/vdsm_hooks/openstacknet/after_device_create.py
@@ -34,7 +34,7 @@
from openstacknet_utils import VNIC_ID_KEY
from openstacknet_utils import devName
from openstacknet_utils import executeOrExit
-from vdsm.constants import EXT_BRCTL
+from openstacknet_utils import EXT_BRCTL
def disconnectVnic(portId):
--
To view, visit https://gerrit.ovirt.org/79254
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee6647bce1eba3042f00ec74742d0cadc8ab329a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: net: move IFDOWN into ifcfg
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: net: move IFDOWN into ifcfg
......................................................................
net: move IFDOWN into ifcfg
Nobody outside the ifcfg configurator needs IFDOWN. It resolves to
/sbin/ifdown on all platforms. This patch localizes the constant into
the network subsystem.
Change-Id: I9c7a40c0763da4e919f4b9187973c9cb0d5f0c54
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M configure.ac
M lib/vdsm/constants.py.in
M lib/vdsm/network/configurators/ifcfg.py
M tests/functional/networkTests.py
4 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/79251/1
diff --git a/configure.ac b/configure.ac
index 80a20d2..23f466c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -336,7 +336,6 @@
AC_PATH_PROG([FUSER_PATH], [fuser], [/sbin/fuser])
AC_PATH_PROG([GREP_PATH], [grep], [/bin/grep])
AC_PATH_PROG([HWCLOCK_PATH], [hwclock], [/usr/sbin/hwclock])
-AC_PATH_PROG([IFDOWN_PATH], [ifdown], [/sbin/ifdown])
AC_PATH_PROG([IFUP_PATH], [ifup], [/sbin/ifup])
AC_PATH_PROG([IONICE_PATH], [ionice], [/usr/bin/ionice])
AC_PATH_PROG([IP_PATH], [ip], [/sbin/ip])
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 127f553..46d2b43 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -108,7 +108,6 @@
EXT_GREP = '@GREP_PATH@'
-EXT_IFDOWN = '@IFDOWN_PATH@'
EXT_IFUP = '@IFUP_PATH@'
EXT_IONICE = '@IONICE_PATH@'
EXT_ISCSIADM = '@ISCSIADM_PATH@'
diff --git a/lib/vdsm/network/configurators/ifcfg.py b/lib/vdsm/network/configurators/ifcfg.py
index a53029e..3acd091 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -68,6 +68,8 @@
CONFFILE_HEADER_SIGNATURE = '# Generated by VDSM version'
+EXT_IFDOWN = '/sbin/ifdown'
+
def is_available():
return True
@@ -844,7 +846,7 @@
def ifdown(iface):
"Bring down an interface"
- rc, _, _ = cmd.exec_sync([constants.EXT_IFDOWN, iface])
+ rc, _, _ = cmd.exec_sync([EXT_IFDOWN, iface])
return rc
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index e0ea749..ae7c79e 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -29,7 +29,8 @@
import six
import vdsm.config
-from vdsm.constants import EXT_BRCTL, EXT_IFUP, EXT_IFDOWN
+from vdsm.constants import EXT_BRCTL, EXT_IFUP
+from vdsm.network.configurators.ifcfg import EXT_IFDOWN
from vdsm.network import ipwrapper
from vdsm.network import netswitch
from vdsm.network.ip import dhclient
--
To view, visit https://gerrit.ovirt.org/79251
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c7a40c0763da4e919f4b9187973c9cb0d5f0c54
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC client: Add methods to subscribe, unsubscribe and notify
......................................................................
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/78657/21/lib/vdsm/client.py
File lib/vdsm/client.py:
Line 214
Line 215
Line 216
Line 217
Line 218
why do you remove that?
--
To view, visit https://gerrit.ovirt.org/78657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5b1e2eace452bf663c34c721bbe3ff9fcabb095
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: RPC: Recieve and parse messages from multiple subscriptions
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Recieve and parse messages from multiple subscriptions
......................................................................
Patch Set 23:
(6 comments)
https://gerrit.ovirt.org/#/c/78656/23//COMMIT_MSG
Commit Message:
Line 7: RPC: Recieve and parse messages from multiple subscriptions
Line 8:
Line 9: JsonRpcClient parses json messages
Line 10: from multiple subscriptions and calls
Line 11: the registered callback.
I really don't understand what you're doing in that patch from the commit msg.. please explain - from the text here I understand that JsonRpcClient parse msgs, and call callbacks.. wasn't it like that before? do you add something new?
Line 12:
Line 13: Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
https://gerrit.ovirt.org/#/c/78656/23/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 363: def __init__(self, transport):
Line 364: self.log = logging.getLogger("jsonrpc.JsonRpcClient")
Line 365: transport.set_message_handler(
Line 366: lambda msg: self._handleMessage(msg)
Line 367: )
why is it needed?
Line 368:
Line 369: self._transport = transport
Line 370: self._runningRequests = {}
Line 371: self._lock = Lock()
Line 417: lambda msg: self._handleMessage(msg, callback)
Line 418: )
Line 419:
Line 420: def unsubscribe(self, sub_id):
Line 421: self._transport.unsubscribe(sub_id)
renaming - separate patch
you can make one patch for all renames. I'd love that
Line 422:
Line 423: def notify(self, event_id, dest, event_schema, params=None):
Line 424: """
Line 425: JsonRpcClient notify method, sends an event on a spesific queue
Line 454: if isinstance(obj, list):
Line 455: map(self._processIncomingResponse, obj)
Line 456: return
Line 457:
Line 458: resp = JsonRpcResponse.fromRawObject(obj)
renaming - separate patch
Line 459: with self._lock:
Line 460: if resp.id is None:
Line 461: self.log.warning(
Line 462: "Got an error from server without an ID (%s)",
Line 487: mobj = json.loads(message)
Line 488: isResponse = self._isResponse(mobj)
Line 489: except:
Line 490: self.log.exception("Problem parsing message from client")
Line 491: return
this is big change\fix... you must explain. it worth separate patch
Line 492:
Line 493: if isResponse:
Line 494: self._processIncomingResponse(mobj)
Line 495: else:
https://gerrit.ovirt.org/#/c/78656/23/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 610
Line 611
Line 612
Line 613
Line 614
no more _handle_message calls?
--
To view, visit https://gerrit.ovirt.org/78656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: RPC: Refactor ClientRpcTransportAdapter
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor ClientRpcTransportAdapter
......................................................................
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/78655/18//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2017-06-26 11:22:07 +0200
Line 4: Commit: Andrej Krejcir <akrejcir(a)redhat.com>
Line 5: CommitDate: 2017-07-11 15:54:35 +0200
Line 6:
Line 7: RPC: Refactor ClientRpcTransportAdapter
if you call it "Refactor" - why not also to move this code out of stompreactor and have all client code in one module.common code between server to client can be maybe in this module/. what do you think?
Line 8:
Line 9: The class now subscribes in the constructor,
Line 10: instead of taking an existing subscription
Line 11: as a parameter.
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: RPC: Refactor ClientRpcTransportAdapter
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor ClientRpcTransportAdapter
......................................................................
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/78655/18//COMMIT_MSG
Commit Message:
Line 7: RPC: Refactor ClientRpcTransportAdapter
Line 8:
Line 9: The class now subscribes in the constructor,
Line 10: instead of taking an existing subscription
Line 11: as a parameter.
what about your addition of response queue.. also interesting to mention
Line 12:
Line 13: Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: RPC: Refactor ClientRpcTransportAdapter
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor ClientRpcTransportAdapter
......................................................................
Patch Set 18: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/78655/18/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 478
Line 479
Line 480
Line 481
Line 482
please do this change in separate patch. it doesn't look related. just removal of redundant code which is awesome!
https://gerrit.ovirt.org/#/c/78655/18/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 584:
Line 585: """
Line 586: In order to process message we need to set message
Line 587: handler which is responsible for processing jsonrpc
Line 588: content of the message.
now we have only 1 handler? specify what type of handle i can set here
Line 589: """
Line 590: def set_message_handler(self, handler):
Line 591: self._message_handler = handler
Line 592:
Line 610: def unsubscribe(self, sub):
Line 611: self._client.unsubscribe(sub)
Line 612:
Line 613: def _handle_message(self, sub, frame):
Line 614: self._message_handler(frame.body)
please do this change in separate patch. it doesn't look related. just removal of redundant code which is awesome!
Line 615:
Line 616: def close(self):
Line 617: self._sub.unsubscribe()
Line 618: self._client.close()
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: RPC: Refactor JSON RPC exceptions
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor JSON RPC exceptions
......................................................................
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/78660
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months