Change in vdsm[ovirt-3.6]: virt net: Interface default driver name set to 'vhost'
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Interface default driver name set to 'vhost'
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79398
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[ovirt-4.1]: net: NM acquire should ignore duplicate ifcfg files
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79378 )
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
net: NM acquire should ignore duplicate ifcfg files
When quering NM DBUS to translate a file path to a connection ID, an
error with "is not an ifcfg base file" is raised when the file is a copy
of an existing ifcfg file (a backup).
This patch ignores these king of error the same way it did for non ifcfg
files that are named with the ifcfg prefix.
Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Bug-Url: https://bugzilla.redhat.com/1441530
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/nm/nmdbus/__init__.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
6 years, 10 months
Change in vdsm[ovirt-4.1]: net: NM acquire should ignore duplicate ifcfg files
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[ovirt-4.1]: net: NM acquire should ignore duplicate ifcfg files
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has removed gerrit-hooks from this change. ( https://gerrit.ovirt.org/79378 )
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
Removed reviewer gerrit-hooks with the following votes:
* Verified-1 by gerrit-hooks <automation(a)ovirt.org>
--
To view, visit https://gerrit.ovirt.org/79378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: net: NM acquire should ignore duplicate ifcfg files
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79349 )
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
net: NM acquire should ignore duplicate ifcfg files
When quering NM DBUS to translate a file path to a connection ID, an
error with "is not an ifcfg base file" is raised when the file is a copy
of an existing ifcfg file (a backup).
This patch ignores these king of error the same way it did for non ifcfg
files that are named with the ifcfg prefix.
Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Bug-Url: https://bugzilla.redhat.com/1441530
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/nm/nmdbus/__init__.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net: NM acquire should ignore duplicate ifcfg files
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: RPC: JsonRpcClient supports multiple subscriptions
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: JsonRpcClient supports multiple subscriptions
......................................................................
Patch Set 31: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/78656/31/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 595: Set a callback which handles messages received
Line 596: from the main RPC queue.
Line 597:
Line 598: :param handler: Callback to handle incoming messages
Line 599: :type handler: function (string) -> ()
so again, what this notion means? sorry for my ignorance.
what function this handler should have? handle_message? lets make interface for that if needed
Line 600: """
Line 601: self._message_handler = handler
Line 602:
Line 603: def send(self, data, destination=None):
--
To view, visit https://gerrit.ovirt.org/78656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: net: move EXT_TC into vdsm.network.tc
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: net: move EXT_TC into vdsm.network.tc
......................................................................
net: move EXT_TC into vdsm.network.tc
The only users of EXT_TC is the tc package and its tests. There is no
need to exposed it in the global constants module.
Change-Id: I40238b99390e150445dfa3d38b8cddb7497045aa
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M configure.ac
M lib/vdsm/constants.py.in
M lib/vdsm/network/tc/__init__.py
M lib/vdsm/network/tc/_wrapper.py
M tests/network/nettestlib.py
M tests/network/tc_test.py
6 files changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/79295/1
diff --git a/configure.ac b/configure.ac
index ddfeb1d..b5e608b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -364,7 +364,6 @@
AC_PATH_PROG([SYSCTL_PATH], [sysctl], [/sbin/sysctl])
AC_PATH_PROG([TAR_PATH], [tar], [/bin/tar])
AC_PATH_PROG([TASKSET_PATH], [taskset], [/usr/bin/taskset])
-AC_PATH_PROG([TC_PATH], [tc], [/sbin/tc])
AC_PATH_PROG([TEE_PATH], [tee], [/usr/bin/tee])
AC_PATH_PROG([TOUCH_PATH], [touch], [/bin/touch])
AC_PATH_PROG([TUNE2FS_PATH], [tune2fs], [/sbin/tune2fs])
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index d35093f..32c87d9 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -110,7 +110,6 @@
EXT_IONICE = '@IONICE_PATH@'
EXT_ISCSIADM = '@ISCSIADM_PATH@'
-EXT_TC = '@TC_PATH@'
EXT_KILL = '@KILL_PATH@'
diff --git a/lib/vdsm/network/tc/__init__.py b/lib/vdsm/network/tc/__init__.py
index bbdc5f7..6f73a30 100644
--- a/lib/vdsm/network/tc/__init__.py
+++ b/lib/vdsm/network/tc/__init__.py
@@ -32,6 +32,7 @@
from ._wrapper import TrafficControlException
QDISC_INGRESS = 'ffff:'
+EXT_TC = '/sbin/tc'
def _addTarget(network, parent, target):
diff --git a/lib/vdsm/network/tc/_wrapper.py b/lib/vdsm/network/tc/_wrapper.py
index 218d5a3..dd2af65 100644
--- a/lib/vdsm/network/tc/_wrapper.py
+++ b/lib/vdsm/network/tc/_wrapper.py
@@ -20,7 +20,7 @@
import errno
import os
-from vdsm.constants import EXT_TC
+from .. import EXT_TC
from vdsm.network import cmd
_TC_ERR_PREFIX = 'RTNETLINK answers: '
diff --git a/tests/network/nettestlib.py b/tests/network/nettestlib.py
index b3d2927..54d9459 100644
--- a/tests/network/nettestlib.py
+++ b/tests/network/nettestlib.py
@@ -32,7 +32,6 @@
from nose.plugins.skip import SkipTest
-from vdsm.constants import EXT_TC
from vdsm import cpuarch
from vdsm.network import cmd as cmd
from vdsm.network.configurators.ifcfg import EXT_BRCTL
@@ -47,6 +46,7 @@
from vdsm.network.link.iface import random_iface_name
from vdsm.network.netinfo import routes
from vdsm.network.netlink import monitor
+from vdsm.network.tc import EXT_TC
from vdsm.common.cache import memoized
from vdsm.common.cmdutils import CommandPath
diff --git a/tests/network/tc_test.py b/tests/network/tc_test.py
index 568dae0..7fbf99f 100644
--- a/tests/network/tc_test.py
+++ b/tests/network/tc_test.py
@@ -43,12 +43,12 @@
from .nettestlib import running
from vdsm import libvirtconnection
-from vdsm.constants import EXT_TC
from vdsm.network import cmd
from vdsm.network import tc
from vdsm.network.configurators import qos
from vdsm.network.ipwrapper import addrAdd, linkSet, netns_exec, link_set_netns
from vdsm.network.netinfo.qos import DEFAULT_CLASSID
+from vdsm.network.tc import EXT_TC
class TestQdisc(TestCaseBase):
--
To view, visit https://gerrit.ovirt.org/79295
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I40238b99390e150445dfa3d38b8cddb7497045aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: RPC: Small refactor of ClientRpcTransportAdapter
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Small refactor of ClientRpcTransportAdapter
......................................................................
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/78655/24/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 595: :param handler: Callback to handle incoming messages
Line 596: :type handler: function (ClientRpcTransportAdapter, string) -> ()
Line 597: """
Line 598: self._message_handler = handler
Line 599:
if you change this area again in https://gerrit.ovirt.org/#/c/78656/30/lib/yajsonrpc/stompreactor.py - just don't touch here at all - try to make this patch small as possible
Line 600: def send(self, data, destination=None):
Line 601: if not destination:
Line 602: destination = self._request_queue
Line 603:
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: RPC: Small refactor of ClientRpcTransportAdapter
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Small refactor of ClientRpcTransportAdapter
......................................................................
Patch Set 24:
why don't you squeeze between this patch to https://gerrit.ovirt.org/#/c/78656/30/lib/yajsonrpc/stompreactor.py ?
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months