Change in vdsm[master]: RPC: Refactor JSON RPC exceptions
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor JSON RPC exceptions
......................................................................
Patch Set 29:
(1 comment)
https://gerrit.ovirt.org/#/c/78660/29//COMMIT_MSG
Commit Message:
Line 13: For example, new error message for JsonRpcMethodNotFoundError is:
Line 14: The method does not exist or is not available: {'method': 'some_missing_method'}
Line 15:
Line 16: Also added a new class JsonRpcGeneralError, that can have
Line 17: any code and message.
> I see... I think, it would be better to put the changes of exceptions to an
Nir, Seems like you have amazing design and appropriate behavior that you would like to have in all vdsm code as maintainer - it sounds amazing. but all those comments can't show me what you want to create - its too long and I can't allow follow the context. please create design document for your desire of how handling error\exception should be in vdsm - what way of using this hierarchy is valid and what is not- like may I create interfaces? can I call super? can I use same message but two different codes? whatever you love, just write it in a way that we will be able to follow your way ... if you did so already, please share it and sorry for the interruption :)
Line 18:
Line 19: Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958
--
To view, visit https://gerrit.ovirt.org/78660
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 9 months
Change in vdsm[master]: net: Allow QoS caps to ignore nets with multiple sb nics
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Allow QoS caps to ignore nets with multiple sb nics
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/79621
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf9aad74622262f841657d1687babea60623d065
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: hooks: support to read/write the raw domain XML
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: support to read/write the raw domain XML
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/79489
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I009c7d03337bf267f9cf7b1b32e884d987d6adb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: net: Get iface mtu using netlink instead of sysfs
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Get iface mtu using netlink instead of sysfs
......................................................................
Patch Set 2: Code-Review+2
no sure about efficiency, but new code looks nicer
--
To view, visit https://gerrit.ovirt.org/79158
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I219e226957cddde922f11a6f490d3f8b89a620c4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: tool: clear networks configured by oVirt
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tool: clear networks configured by oVirt
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/79495/1/lib/vdsm/tool/network.py
File lib/vdsm/tool/network.py:
Line 121: networks_request[net] = {'remove': True}
Line 122: net_api.setupNetworks(networks_request, {}, {'connectivityCheck': False})
Line 123:
Line 124:
Line 125: def _remove_dummy_network():
this monstrosity is added in lib/vdsm/tool/dummybr.py. it is not a vdsm network, only a means to persist the dummy bridge.
Please add the bridge removal to dummybr.py (possibly in a separate patch)
Line 126: if os.path.exists('/sys/class/net/{}'.format(net_api.DUMMY_BRIDGE)):
Line 127: commands.execCmd([constants.EXT_BRCTL, 'delbr', net_api.DUMMY_BRIDGE])
Line 128:
Line 129: dummy_network = _get_libvirt_network_by_name(net_api.DUMMY_BRIDGE)
--
To view, visit https://gerrit.ovirt.org/79495
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63702da4dd1c5a0328797f524734813ef251bdb6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 9 months
Change in vdsm[master]: network: remove ip from a nic used by a removed network
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/76937 )
Change subject: network: remove ip from a nic used by a removed network
......................................................................
network: remove ip from a nic used by a removed network
Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1432386
---
M lib/vdsm/network/configurators/ifcfg.py
M tests/network/func_net_basic_test.py
M tests/network/func_static_ip_test.py
3 files changed, 63 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76937
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[ovirt-3.6]: sos: fix addCopySpecLimit call
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: sos: fix addCopySpecLimit call
......................................................................
sos: fix addCopySpecLimit call
sosreport 3.4 replace add_copy_spec_limit with
add_copy_spec.
commit 2e2559d4f3dd7625e52aad3314379ef1ee2afe41 replaced
this call but apperantly in prior sosreport versions,
number of parameters of add_copy_spec method was different and
caused a TypeError.
Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1471663
---
M vdsm/sos/vdsm.py.in
1 file changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/79542/1
diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index 3dfe177..ec9d860 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -54,6 +54,11 @@
# Make compatible com sos version >= 3
if not hasattr(Plugin, 'addCopySpec'):
addCopySpec = Plugin.add_copy_spec
+ # sosreport 3.4 replaced add_copy_spec_limit with add_copy_spec
+ if hasattr(Plugin, 'add_copy_spec_limit'):
+ addCopySpecLimit = Plugin.add_copy_spec_limit
+ else:
+ addCopySpecLimit = Plugin.add_copy_spec
collectExtOutput = Plugin.add_cmd_output
getOption = Plugin.get_option
addForbiddenPath = Plugin.add_forbidden_path
@@ -70,8 +75,12 @@
self.addCopySpec("/etc/vdsm/*")
self.addCopySpec("/etc/vdsm-reg/*")
logsize = self.getOption('logsize')
- self.addCopySpec("/var/log/vdsm/*", logsize)
- self.addCopySpec("/var/log/vdsm-reg/*", logsize)
+ if logsize is not None:
+ self.addCopySpecLimit("/var/log/vdsm/*", logsize)
+ self.addCopySpecLimit("/var/log/vdsm-reg/*", logsize)
+ else:
+ self.addCopySpec("/var/log/vdsm/*")
+ self.addCopySpec("/var/log/vdsm-reg/*")
self._addVdsmRunDir()
self.addCopySpec("@TRUSTSTORE@")
self.addCopySpec("@HOOKSDIR@")
--
To view, visit https://gerrit.ovirt.org/79542
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
6 years, 9 months
Change in vdsm[master]: static: use tabs for indetation in Makefile
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79494 )
Change subject: static: use tabs for indetation in Makefile
......................................................................
static: use tabs for indetation in Makefile
Change-Id: I6a6979a2bf1a301930d88501202fd886f6197e9b
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M static/Makefile.am
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a6979a2bf1a301930d88501202fd886f6197e9b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: static: use tabs for indetation in Makefile
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: static: use tabs for indetation in Makefile
......................................................................
Patch Set 1: Code-Review+2 Verified+1
Sorry!
--
To view, visit https://gerrit.ovirt.org/79494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6979a2bf1a301930d88501202fd886f6197e9b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: sos: fix addCopySpecLimit call
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: sos: fix addCopySpecLimit call
......................................................................
sos: fix addCopySpecLimit call
sosreport 3.4 replace add_copy_spec_limit with
add_copy_spec.
commit 2e2559d4f3dd7625e52aad3314379ef1ee2afe41 replaced
this call but apperantly in prior sosreport versions,
number of parameters of add_copy_spec method was different and
caused a TypeError.
Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1471663
---
M vdsm/sos/vdsm.py.in
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/79541/1
diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index b08bb6e..03ef206 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -66,6 +66,11 @@
# Make compatible com sos version >= 3
if not hasattr(Plugin, 'addCopySpec'):
addCopySpec = Plugin.add_copy_spec
+ # sosreport 3.4 replaced add_copy_spec_limit with add_copy_spec
+ if hasattr(Plugin, 'add_copy_spec_limit'):
+ addCopySpecLimit = Plugin.add_copy_spec_limit
+ else:
+ addCopySpecLimit = Plugin.add_copy_spec
collectExtOutput = Plugin.add_cmd_output
getOption = Plugin.get_option
addForbiddenPath = Plugin.add_forbidden_path
@@ -89,7 +94,10 @@
self.addCopySpec("/tmp/vds_bootstrap*")
self.addCopySpec("/etc/vdsm/*")
logsize = self.getOption('logsize')
- self.addCopySpec("/var/log/vdsm/*", logsize)
+ if logsize is not None:
+ self.addCopySpecLimit("/var/log/vdsm/*", logsize)
+ else:
+ self.addCopySpec("/var/log/vdsm/*")
self._addVdsmRunDir()
self.addCopySpec("@HOOKSDIR@")
self.addCopySpec("@VDSMLIBDIR@")
--
To view, visit https://gerrit.ovirt.org/79541
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
6 years, 9 months