Hi,
Thank you very much Mirek for the review, here’s a fixed version.
First it does not apply cleanly. Please rebase on mater and send
output of
git format-patch HEAD~1
instead of
git show
Done.
Very bad habit, sorry :-/
Anyway I resolved two conflicts there manually, but I am getting;
You must set "%_gpg_name" in your macro file
Despite the fact that I have it in my
~/.rpmmacros
despite the fact I put it into
config_opts['macros']['%_gpg_name'] = "msuchy"
in site-defaults.cfg
It looks like mock mess with the environment, and by the time the sign
plugin is invoked, os.environ[‘HOME’] contains /builddir which prevent rpm
—addsign to work. To be honest, we sign with a different tool so I didn’t
tested enough 'rpm —addsign'
I updated the site-defaults.cfg with a way to make it work using -D options
Another problem can be, that the plugin is executed as root.
You may want to call
self.uid_manager.dropPrivsTemp()
before calling do()
and then:
self.buildroot.uid_manager.restorePrivs()
Done. Thank you for pointing that out !