[Patch][Pungi] log file formating

[Joel Andres Granados]

Hi list:

I have noticed that the resulting log file contains some strange looking 
output.  Mainly the output of createrepo and mksquashfs from the 
buildinstall call.  AFAIK the problem is caused because these two 
applications use the '\r' in there outputs. When using the 
universal_newlines option the log file improves a little bit.
The diff is attached
regards.

diff --git a/pypungi/pungi.py b/pypungi/pungi.py
index 3f74669..018bb31 100755
--- a/pypungi/pungi.py
+++ b/pypungi/pungi.py
@@ -69,7 +69,7 @@ class Pungi:

log.info("Running %s" % ' '.join(command))

-        p1 = subprocess.Popen(command, cwd=rundir, stdout=output, stderr=error)
+        p1 = subprocess.Popen(command, cwd=rundir, stdout=output, stderr=error, universal_newlines=True)
         (out, err) = p1.communicate()
         if p1.returncode != 0:
             log.error("Got an error from %s" % command[0])

[Jesse Keating]

On Wednesday 23 May 2007 11:22:45 Joel Andres Granados wrote:
> I have noticed that the resulting log file contains some strange looking
> output.  Mainly the output of createrepo and mksquashfs from the
> buildinstall call.  AFAIK the problem is caused because these two
> applications use the '\r' in there outputs. When using the
> universal_newlines option the log file improves a little bit.
> The diff is attached

Thanks.  I'm going to rework some of the logging post f7 anyway, so I'll 
include this too.

[Joel Andres Granados]

Jesse Keating wrote:
> On Wednesday 23 May 2007 11:22:45 Joel Andres Granados wrote:
> > I have noticed that the resulting log file contains some strange looking
> > output.  Mainly the output of createrepo and mksquashfs from the
> > buildinstall call.  AFAIK the problem is caused because these two
> > applications use the '\r' in there outputs. When using the
> > universal_newlines option the log file improves a little bit.
> > The diff is attached
>
> Thanks.  I'm going to rework some of the logging post f7 anyway, so I'll 
> include this too.
>
> --
> Fedora-buildsys-list mailing list
> [e-mail]
> https://www.redhat.com/mailman/listinfo/fedora-buildsys-list

FYI.  I believe this to be temporary fix for the ugliness in the log 
file.  I just don't see a reason to have the progress information 
expressed in individual lines [1] except for maybe the chance of seeing 
exactly in what moment of the createrepo or mksquashfs processes 
failed.  Additionally if pungi where to redirect this output to its 
stdout it would look rather ugly in the CL ( but for know it works for 
the log file since there is no verbose option).
IMO  there can be *MAYBE* (Im still very touchy feely here) two solutions:
1. Do away with the createrepo and mksquashfs outputs (createrepo has a 
quiet options, mksquashfs has a "no progress option" but buildinstall 
would have to be modified to use this option).  In the end the log file 
and the stdout can be the same without any ugliness (I think :)
2. Create a special object for the file log handler that simple ignores 
the messages that come from createrepo and mksquashfs and logs 
everything else.  In this way pungis stdout can still have the 
createrepo and mksquashfs outputs while the log ignores them altogether.

Not sure :(.  Any feedback is appreciated!!!
Regards.

[1]  The output with patch for the log file:
1/508 - Fedora/libFS-1.0.0-3.1.x86_64.rpm

2/508 - Fedora/kernel-debug-2.6.21-1.3175.fc7.x86_64.rpm

3/508 - Fedora/perl-devel-5.8.8-18.fc7.x86_64.rpm

4/508 - Fedora/avahi-glib-0.6.17-1.fc7.i386.rpm

5/508 - Fedora/rpm-4.4.2-46.fc7.x86_64.rpm

6/508 - Fedora/shared-mime-info-0.20-2.fc7.x86_64.rpm

7/508 - Fedora/grub-0.97-13.x86_64.rpm

8/508 - Fedora/dmraid-1.0.0.rc14-2.fc7.x86_64.rpm

9/508 - Fedora/libdhcp6client-0.10-42.fc7.x86_64.rpm

[Jesse Keating]

On Wednesday 23 May 2007 12:07:27 Joel Andres Granados wrote:
> FYI.  I believe this to be temporary fix for the ugliness in the log
> file.  I just don't see a reason to have the progress information
> expressed in individual lines [1] except for maybe the chance of seeing
> exactly in what moment of the createrepo or mksquashfs processes
> failed.  Additionally if pungi where to redirect this output to its
> stdout it would look rather ugly in the CL ( but for know it works for
> the log file since there is no verbose option).
> IMO  there can be *MAYBE* (Im still very touchy feely here) two solutions:
> Do away with the createrepo and mksquashfs outputs (createrepo has a
>
> quiet options, mksquashfs has a "no progress option" but buildinstall
> would have to be modified to use this option).  In the end the log file
> and the stdout can be the same without any ugliness (I think :)
> 2. Create a special object for the file log handler that simple ignores
> the messages that come from createrepo and mksquashfs and logs
> everything else.  In this way pungis stdout can still have the
> createrepo and mksquashfs outputs while the log ignores them altogether.
>
> Not sure :(.  Any feedback is appreciated!!!

I think it is important to gather all the output from things we call and put 
them into the log.  If createrepo barfs on a package I want to know where it 
was or things like that.  Perhaps we just need to fix createrepo and 
mksquashfs to handle their output better in situations?